Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1037803002: Return timestamp of the last recorded interval to the caller of HeapProfiler::GetHeapStats (Closed)

Created:
5 years, 9 months ago by yurys
Modified:
5 years, 9 months ago
Reviewers:
alph, Yang, loislo
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Return timestamp of the last recorded interval to the caller of HeapProfiler::GetHeapStats Before this patch the embedder could assign timestamp to the last interval after calling GetHeapStats. This would be slightly different from the timstamps assigned by v8 internally and written into heap snapshot. This patch allow to avoid this small discrepancy by returning timestamp along with last heap stats update. BUG=chromium:467222 LOG=Y Committed: https://crrev.com/f13d04d28cf1eb8d6783416d8d3a1d71d82df846 Cr-Commit-Position: refs/heads/master@{#27466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M include/v8-profiler.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/api.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/heap-profiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap-profiler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap-snapshot-generator.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 2 chunks +6 lines, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
yurys
5 years, 9 months ago (2015-03-25 16:38:25 UTC) #2
alph
lgtm
5 years, 9 months ago (2015-03-25 16:48:54 UTC) #3
yurys
I'm going to wait with landing Blink code that uses the new API until Chrome ...
5 years, 9 months ago (2015-03-25 16:49:49 UTC) #4
Yang
On 2015/03/25 16:49:49, yurys wrote: > I'm going to wait with landing Blink code that ...
5 years, 9 months ago (2015-03-26 08:16:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037803002/1
5 years, 9 months ago (2015-03-26 08:17:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1555)
5 years, 9 months ago (2015-03-26 08:34:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037803002/1
5 years, 9 months ago (2015-03-26 08:35:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 08:49:59 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 08:50:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f13d04d28cf1eb8d6783416d8d3a1d71d82df846
Cr-Commit-Position: refs/heads/master@{#27466}

Powered by Google App Engine
This is Rietveld 408576698