Force mini_installer to be optimized for size for the official builds.

Force mini_installer to be optimized for size for the official builds.

It doesn't change anything to the current official build configuration ! 'size' is already the default value for the 'optimize' variable (https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&l=5411), but we override this value when doing a PGO build, so this is just preventing the mini_installer from being PGO optimized.

BUG=309849
Committed: https://crrev.com/b126d91631349406592514cb1a32c26f8fd79d62
Cr-Commit-Position: refs/heads/master@{#322198}

[Sébastien Marchand, 2015-03-25 17:34:29]

Patchset #1 (id:1) has been deleted

[Sébastien Marchand, 2015-03-25 17:34:34]

Patchset #2 (id:40001) has been deleted

[Sébastien Marchand, 2015-03-25 17:36:01]

Patchset #1 (id:20001) has been deleted

[Sébastien Marchand, 2015-03-25 17:39:17]

sebmarchand@chromium.org changed reviewers:
+ gab@chromium.org, robertshield@chromium.org

[Sébastien Marchand, 2015-03-25 17:39:54]

PTAL.

[robertshield, 2015-03-25 17:55:41]

lgtm

[Sébastien Marchand, 2015-03-25 17:56:48]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2015-03-25 17:56:49]

Thanks, committing !

[commit-bot: I haz the power, 2015-03-25 17:57:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1037793004/60001

[commit-bot: I haz the power, 2015-03-25 18:42:12]

Committed patchset #1 (id:60001)

[commit-bot: I haz the power, 2015-03-25 18:43:06]

Patchset 1 (id:??) landed as
https://crrev.com/b126d91631349406592514cb1a32c26f8fd79d62
Cr-Commit-Position: refs/heads/master@{#322198}

[Will Harris, 2015-03-26 00:01:27]

wfh@chromium.org changed reviewers:
+ grt@chromium.org
- robertshield@chromium.org

[Will Harris, 2015-03-26 00:01:36]

I have a feeling that the mini_installer output from a chromium build is
discarded when building an official signed release, because it's rebuilt on
pulse.  I might be wrong though. +grt

[grt (UTC plus 2), 2015-03-26 13:42:07]

On 2015/03/26 00:01:36, Will Harris wrote:
> I have a feeling that the mini_installer output from a chromium build is
> discarded when building an official signed release, because it's rebuilt on
> pulse.  I might be wrong though. +grt

Yes. You can do whatever you want in this file, and it will have no impact on
the official mini_installer.exe (http://crbug.com/36234). Please keep
mini_installer.gyp, mini_installer.gypi, and the actual signing script in sync.
Some day we will fix the aforementioned bug, and it would be nice for things to
Just Work(TM) when we do so.

Seb: why does syzygy have this mini_installer.gypi that duplicates
mini_installer.gyp? Can we cut out one of the three things that says how to
build mini_installer.exe?

[Sébastien Marchand, 2015-03-26 14:28:14]

On 2015/03/26 13:42:07, grt wrote:
> On 2015/03/26 00:01:36, Will Harris wrote:
> > I have a feeling that the mini_installer output from a chromium build is
> > discarded when building an official signed release, because it's rebuilt on
> > pulse.  I might be wrong though. +grt
> 
> Yes. You can do whatever you want in this file, and it will have no impact on
> the official mini_installer.exe (http://crbug.com/36234). Please keep
> mini_installer.gyp, mini_installer.gypi, and the actual signing script in
sync.
> Some day we will fix the aforementioned bug, and it would be nice for things
to
> Just Work(TM) when we do so.
> 
> Seb: why does syzygy have this mini_installer.gypi that duplicates
> mini_installer.gyp? Can we cut out one of the three things that says how to
> build mini_installer.exe?

I think that the idea was to move stuffs out of mini_installer.gyp and put them
in mini_installer.gypi, so they can easily be re-used elsewhere (in
mini_installer_syzygy.gyp in this case). Things have derailed a little bit and
it looks like there's some duplicated code in mini_installer.gypi and
mini_installer.gyp which could probably be cleaned up...

[grt (UTC plus 2), 2015-03-26 15:51:33]

On 2015/03/26 14:28:14, Sébastien Marchand wrote:
> On 2015/03/26 13:42:07, grt wrote:
> > On 2015/03/26 00:01:36, Will Harris wrote:
> > > I have a feeling that the mini_installer output from a chromium build is
> > > discarded when building an official signed release, because it's rebuilt
on
> > > pulse.  I might be wrong though. +grt
> > 
> > Yes. You can do whatever you want in this file, and it will have no impact
on
> > the official mini_installer.exe (http://crbug.com/36234). Please keep
> > mini_installer.gyp, mini_installer.gypi, and the actual signing script in
> sync.
> > Some day we will fix the aforementioned bug, and it would be nice for things
> to
> > Just Work(TM) when we do so.
> > 
> > Seb: why does syzygy have this mini_installer.gypi that duplicates
> > mini_installer.gyp? Can we cut out one of the three things that says how to
> > build mini_installer.exe?
> 
> I think that the idea was to move stuffs out of mini_installer.gyp and put
them
> in mini_installer.gypi, so they can easily be re-used elsewhere (in
> mini_installer_syzygy.gyp in this case). Things have derailed a little bit and
> it looks like there's some duplicated code in mini_installer.gypi and
> mini_installer.gyp which could probably be cleaned up...

I've filed http://crbug.com/470889 for this cleanup. Since syzygy team created
the duplication, I'd appreciate it if someone on the team could de-dup somehow.
I'm happy to help any way I can. Thanks.