nacl sdk: add PPB_VideoEncoder example

nacl sdk: add PPB_VideoEncoder example

BUG=455409
Committed: https://crrev.com/8358371b07de0489a18a0f182188cdbf1c54919d
Cr-Commit-Position: refs/heads/master@{#324026}

[llandwerlin-old, 2015-03-25 17:28:23]

lionel.g.landwerlin@intel.com changed reviewers:
+ binji@chromium.org

[llandwerlin-old, 2015-03-25 17:28:24]

PTAL, Thanks.

[llandwerlin-old, 2015-03-25 17:28:43]

lionel.g.landwerlin@intel.com changed reviewers:
+ bbudge@chromium.org

[bbudge, 2015-03-25 17:35:01]

lgtm

[llandwerlin-old, 2015-03-30 13:24:50]

Any idea what's the annotated_steps doing?
There is no message that could help to fix the problem.

[Sam Clegg, 2015-03-30 14:57:45]

On 2015/03/30 13:24:50, llandwerlin wrote:
> Any idea what's the annotated_steps doing?
> There is no message that could help to fix the problem.

Looks like the final step contains this failure:
video_encode.cc:297: error: comparison between signed and unsigned integer
expressions


Previously I think that the failing step would be red, and also the full
stdout/stderr of all steps would be combined in the stdoud/stderr of the
annotated steps.  I guess something changed recently with the way we run
annotator steps.

[llandwerlin-old, 2015-03-30 15:05:50]

On 2015/03/30 14:57:45, Sam Clegg wrote:
> On 2015/03/30 13:24:50, llandwerlin wrote:
> > Any idea what's the annotated_steps doing?
> > There is no message that could help to fix the problem.
> 
> Looks like the final step contains this failure:
> video_encode.cc:297: error: comparison between signed and unsigned integer
> expressions
> 
> 
> Previously I think that the failing step would be red, and also the full
> stdout/stderr of all steps would be combined in the stdoud/stderr of the
> annotated steps.  I guess something changed recently with the way we run
> annotator steps.

Thanks a lot for that.

[llandwerlin-old, 2015-03-30 17:28:48]

PTAL, Thanks.

[binji, 2015-03-31 17:41:19]

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
File native_client_sdk/src/examples/api/video_encode/example.js (right):

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:35:
$('length').innerHTML = ' Size: ' + window.dataArray.byteLength + ' bytes';
please define global variables at the top of the file, and don't use window.*

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:38: }
disable the start button and enable the stop button.

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:48: }
disable the stop button and enable the start button and download button

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:51: var blobUrl =
URL.createObjectURL(blob);
Use the html5 download attribute instead. That way you can specify a nice
download name instead of the ugly blob url name:
http://updates.html5rocks.com/2011/08/Downloading-resources-in-HTML5-a-download

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:56: if (msg.data.name
== 'started') {
this message never fires on my machine -- I get an error "Error: Var(-6) :
Cannot get supported profiles". Perhaps the start/stop buttons should be
disabled until the "supportedProfiles" message is received?

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:57:
console.log('recording!');
display this to the user, not just the javascript console log. You can use
common.logMessage(...).

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:61: console.log('done
recording! bytes: ' + window.dataArray.byteLength);
common.logMessage

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:62: } else if
(msg.data.name == 'supportedProfiles') {
I tested this on my linux box and this message has an array of length 0. Handle
this case by disabling the start button and displaying an error to the user?

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:84:
$('length').innerHTML = ' Size: ' + window.dataArray.byteLength + ' bytes';
use textContent instead of innerHTML

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
File native_client_sdk/src/examples/api/video_encode/video_encode.cc (right):

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/video_encode.cc:567:
LogToConsole(PP_LOGLEVEL_LOG, pp::Var(message));
It would be nice to have these errors log to the html document instead of the
console. Perhaps add a new message type ("log"?) and handle that in the
JavaScript handleMessage function.

[llandwerlin-old, 2015-04-02 09:59:01]

PTAL, Thanks.

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
File native_client_sdk/src/examples/api/video_encode/example.js (right):

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:35:
$('length').innerHTML = ' Size: ' + window.dataArray.byteLength + ' bytes';
On 2015/03/31 17:41:19, binji wrote:
> please define global variables at the top of the file, and don't use window.*

Done.

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:38: }
On 2015/03/31 17:41:19, binji wrote:
> disable the start button and enable the stop button.

Done.

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:48: }
On 2015/03/31 17:41:19, binji wrote:
> disable the stop button and enable the start button and download button

Done.

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:51: var blobUrl =
URL.createObjectURL(blob);
On 2015/03/31 17:41:19, binji wrote:
> Use the html5 download attribute instead. That way you can specify a nice
> download name instead of the ugly blob url name:
>
http://updates.html5rocks.com/2011/08/Downloading-resources-in-HTML5-a-download

Done.

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:56: if (msg.data.name
== 'started') {
On 2015/03/31 17:41:19, binji wrote:
> this message never fires on my machine -- I get an error "Error: Var(-6) :
> Cannot get supported profiles". Perhaps the start/stop buttons should be
> disabled until the "supportedProfiles" message is received?

You must have tested before https://codereview.chromium.org/956893002 landed,
and might not have any supported profiles.
Will disable all buttons until the profiles are reported.

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:57:
console.log('recording!');
On 2015/03/31 17:41:19, binji wrote:
> display this to the user, not just the javascript console log. You can use
> common.logMessage(...).

Done.

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:61: console.log('done
recording! bytes: ' + window.dataArray.byteLength);
On 2015/03/31 17:41:19, binji wrote:
> common.logMessage

Done.

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:62: } else if
(msg.data.name == 'supportedProfiles') {
On 2015/03/31 17:41:19, binji wrote:
> I tested this on my linux box and this message has an array of length 0.
Handle
> this case by disabling the start button and displaying an error to the user?

https://codereview.chromium.org/956893002 added support for a software VP8
encoder. With this we should always get at least one profile supported.

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/example.js:84:
$('length').innerHTML = ' Size: ' + window.dataArray.byteLength + ' bytes';
On 2015/03/31 17:41:19, binji wrote:
> use textContent instead of innerHTML

Done.

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
File native_client_sdk/src/examples/api/video_encode/video_encode.cc (right):

https://codereview.chromium.org/1037793003/diff/1/native_client_sdk/src/examp...
native_client_sdk/src/examples/api/video_encode/video_encode.cc:567:
LogToConsole(PP_LOGLEVEL_LOG, pp::Var(message));
On 2015/03/31 17:41:19, binji wrote:
> It would be nice to have these errors log to the html document instead of the
> console. Perhaps add a new message type ("log"?) and handle that in the
> JavaScript handleMessage function.

Done.

[binji, 2015-04-06 16:20:32]

lgtm

[llandwerlin-old, 2015-04-07 08:45:57]

The CQ bit was checked by lionel.g.landwerlin@intel.com

[llandwerlin-old, 2015-04-07 08:45:58]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org
Link to the patchset: https://codereview.chromium.org/1037793003/#ps60001
(title: "Update after binji's review")

[commit-bot: I haz the power, 2015-04-07 08:46:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1037793003/60001

[commit-bot: I haz the power, 2015-04-07 09:16:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-07 09:17:42]

Patchset 4 (id:??) landed as
https://crrev.com/8358371b07de0489a18a0f182188cdbf1c54919d
Cr-Commit-Position: refs/heads/master@{#324026}