Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: site/dev/contrib/style.md

Issue 1037793002: C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: git cl web Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « site/dev/contrib/flatten.md ('k') | site/user/sample/hello.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: site/dev/contrib/style.md
diff --git a/site/dev/contrib/style.md b/site/dev/contrib/style.md
index ac31f4ad56de0075a5b38b7bc8757ccba37417ff..e952ed1b68b93a04f8552548aa051a583ef841c1 100644
--- a/site/dev/contrib/style.md
+++ b/site/dev/contrib/style.md
@@ -321,12 +321,12 @@ private:
};
~~~~
-Virtual functions that are overridden in derived classes should use SK_OVERRIDE
+Virtual functions that are overridden in derived classes should use override
(and not the override keyword). The virtual keyword can be omitted.
<!--?prettify?-->
~~~~
-void myVirtual() SK_OVERRIDE {
+void myVirtual() override {
}
~~~~
@@ -335,7 +335,7 @@ base-class implementations of a virtual function should be explicitly qualified:
<!--?prettify?-->
~~~~
-void myVirtual() SK_OVERRIDE {
+void myVirtual() override {
...
this->INHERITED::myVirtual();
...
@@ -343,7 +343,7 @@ void myVirtual() SK_OVERRIDE {
~~~~
As in the above example, derived classes that redefine virtual functions should
-use SK_OVERRIDE to note that explicitly.
+use override to note that explicitly.
Constructor initializers should be one per line, indented, with punctuation
placed before the initializer. This is a fairly new rule so much of the existing
« no previous file with comments | « site/dev/contrib/flatten.md ('k') | site/user/sample/hello.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698