experimental/PdfViewer/src/SkPdfRenderer.cpp - Issue 1037793002: C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: experimental/PdfViewer/src/SkPdfRenderer.cpp

Issue 1037793002: C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: git cl web Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: experimental/PdfViewer/src/SkPdfRenderer.cpp

diff --git a/experimental/PdfViewer/src/SkPdfRenderer.cpp b/experimental/PdfViewer/src/SkPdfRenderer.cpp

index 037606694e3de76a656ecbba75ce8b96dd6810fd..ead65039a64f5aa39f46473be5d79755f9a89053 100644

--- a/experimental/PdfViewer/src/SkPdfRenderer.cpp

+++ b/experimental/PdfViewer/src/SkPdfRenderer.cpp

@@ -212,8 +212,8 @@ public:

explicit PdfInlineImageLooper(SkPdfTokenLooper* parent)

: INHERITED(parent) {}

- SkPdfResult consumeToken(PdfToken& token) SK_OVERRIDE;

- void loop() SK_OVERRIDE;

+ SkPdfResult consumeToken(PdfToken& token) override;

+ void loop() override;

private:

typedef SkPdfTokenLooper INHERITED;

@@ -224,8 +224,8 @@ public:

explicit PdfCompatibilitySectionLooper(SkPdfTokenLooper* parent)

: INHERITED (parent) {}