Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/PictureResultsWriter.h

Issue 1037793002: C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: git cl web Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/PictureRenderer.h ('k') | tools/iOSShell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/PictureResultsWriter.h
diff --git a/tools/PictureResultsWriter.h b/tools/PictureResultsWriter.h
index d3d346fd1cd37e6efde648c46d44d3ef9767f4aa..67371024e395773f53bf18cf52ad9e24238c1063 100644
--- a/tools/PictureResultsWriter.h
+++ b/tools/PictureResultsWriter.h
@@ -56,22 +56,22 @@ public:
fWriters.push_back(newWriter);
}
virtual ~PictureResultsMultiWriter() {}
- void bench(const char name[], int32_t x, int32_t y) SK_OVERRIDE {
+ void bench(const char name[], int32_t x, int32_t y) override {
for(int i=0; i<fWriters.count(); ++i) {
fWriters[i]->bench(name, x, y);
}
}
- void logRenderer(sk_tools::PictureRenderer *pr) SK_OVERRIDE {
+ void logRenderer(sk_tools::PictureRenderer *pr) override {
for(int i=0; i<fWriters.count(); ++i) {
fWriters[i]->logRenderer(pr);
}
}
- void tileMeta(int x, int y, int tx, int ty) SK_OVERRIDE {
+ void tileMeta(int x, int y, int tx, int ty) override {
for(int i=0; i<fWriters.count(); ++i) {
fWriters[i]->tileMeta(x, y, tx, ty);
}
}
- void addTileFlag(PictureResultsWriter::TileFlags flag) SK_OVERRIDE {
+ void addTileFlag(PictureResultsWriter::TileFlags flag) override {
for(int i=0; i<fWriters.count(); ++i) {
fWriters[i]->addTileFlag(flag);
}
@@ -81,13 +81,13 @@ public:
const char format[],
const TimerData::Result result,
uint32_t timerTypes,
- int numInnerLoops = 1) SK_OVERRIDE {
+ int numInnerLoops = 1) override {
for(int i=0; i<fWriters.count(); ++i) {
fWriters[i]->tileData(data, format, result, timerTypes,
numInnerLoops);
}
}
- void end() SK_OVERRIDE {
+ void end() override {
for(int i=0; i<fWriters.count(); ++i) {
fWriters[i]->end();
}
@@ -109,18 +109,18 @@ private:
public:
PictureResultsLoggerWriter(BenchLogger* log)
: fLogger(log), fCurrentLine() {}
- void bench(const char name[], int32_t x, int32_t y) SK_OVERRIDE {
+ void bench(const char name[], int32_t x, int32_t y) override {
SkString result;
result.printf("running bench [%i %i] %s ", x, y, name);
this->logProgress(result.c_str());
}
- void logRenderer(sk_tools::PictureRenderer* renderer) SK_OVERRIDE {
+ void logRenderer(sk_tools::PictureRenderer* renderer) override {
fCurrentLine = renderer->getConfigName();
}
- void tileMeta(int x, int y, int tx, int ty) SK_OVERRIDE {
+ void tileMeta(int x, int y, int tx, int ty) override {
fCurrentLine.appendf(": tile [%i,%i] out of [%i,%i]", x, y, tx, ty);
}
- void addTileFlag(PictureResultsWriter::TileFlags flag) SK_OVERRIDE {
+ void addTileFlag(PictureResultsWriter::TileFlags flag) override {
if(flag == PictureResultsWriter::kPurging) {
fCurrentLine.append(" <withPurging>");
} else if(flag == PictureResultsWriter::kAvg) {
@@ -132,13 +132,13 @@ public:
const char format[],
const TimerData::Result result,
uint32_t timerTypes,
- int numInnerLoops = 1) SK_OVERRIDE {
+ int numInnerLoops = 1) override {
SkString results = data->getResult(format, result,
fCurrentLine.c_str(), timerTypes, numInnerLoops);
results.append("\n");
this->logProgress(results.c_str());
}
- void end() SK_OVERRIDE {}
+ void end() override {}
private:
BenchLogger* fLogger;
SkString fCurrentLine;
@@ -189,23 +189,23 @@ public:
fBuilderData = this->makeBuilderJson();
}
- void bench(const char name[], int32_t x, int32_t y) SK_OVERRIDE {
+ void bench(const char name[], int32_t x, int32_t y) override {
fBenchName = SkString(name);
}
- void logRenderer(sk_tools::PictureRenderer* pr) SK_OVERRIDE {
+ void logRenderer(sk_tools::PictureRenderer* pr) override {
fParams = pr->getJSONConfig();
fConfigString = pr->getConfigName();
}
// Apparently tiles aren't used, so tileMeta is empty
- void tileMeta(int x, int y, int tx, int ty) SK_OVERRIDE {}
+ void tileMeta(int x, int y, int tx, int ty) override {}
// Flags aren't used, so addTileFlag is empty
- void addTileFlag(PictureResultsWriter::TileFlags flag) SK_OVERRIDE {}
+ void addTileFlag(PictureResultsWriter::TileFlags flag) override {}
virtual void tileData(
TimerData* data,
const char format[],
const TimerData::Result result,
uint32_t timerTypes,
- int numInnerLoops = 1) SK_OVERRIDE {
+ int numInnerLoops = 1) override {
Json::Value newData = data->getJSON(timerTypes, result, numInnerLoops);
Json::Value combinedParams(fBuilderData);
for(Json::ValueIterator iter = fParams.begin(); iter != fParams.end();
@@ -241,7 +241,7 @@ public:
fStream.writeText(Json::FastWriter().write(data).c_str());
}
}
- void end() SK_OVERRIDE {
+ void end() override {
fStream.flush();
}
private:
« no previous file with comments | « tools/PictureRenderer.h ('k') | tools/iOSShell.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698