Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: third_party/instrumented_libraries/instrumented_libraries.gyp

Issue 1037763002: Instrumented libraries: allow overriding CC/CXX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/instrumented_libraries/instrumented_libraries.gyp
diff --git a/third_party/instrumented_libraries/instrumented_libraries.gyp b/third_party/instrumented_libraries/instrumented_libraries.gyp
index 050ed0917395bbd1863c707a4c0a7b1fc4bb8a0e..ea0c65950321d2841a8ccc71811838796db9dc63 100644
--- a/third_party/instrumented_libraries/instrumented_libraries.gyp
+++ b/third_party/instrumented_libraries/instrumented_libraries.gyp
@@ -6,10 +6,14 @@
'variables': {
'verbose_libraries_build%': 0,
'instrumented_libraries_jobs%': 1,
+ 'instrumented_libraries_cc%': '',
+ 'instrumented_libraries_cxx%': '',
},
'libdir': 'lib',
'ubuntu_release': '<!(lsb_release -cs)',
+ 'clang_absolute_path': '<!(cd <(DEPTH) && pwd -P)/<(make_clang_dir)/bin/clang',
+ 'clang++_absolute_path': '<!(cd <(DEPTH) && pwd -P)/<(make_clang_dir)/bin/clang++',
'conditions': [
['asan==1', {
@@ -22,11 +26,19 @@
'sanitizer_type': 'tsan',
}],
['use_goma==1', {
- 'cc': '<(gomadir)/gomacc <!(cd <(DEPTH) && pwd -P)/<(make_clang_dir)/bin/clang',
- 'cxx': '<(gomadir)/gomacc <!(cd <(DEPTH) && pwd -P)/<(make_clang_dir)/bin/clang++',
+ 'cc': '<(gomadir)/gomacc <(_clang_absolute_path)',
+ 'cxx': '<(gomadir)/gomacc <(_clang++_absolute_path)',
}, {
- 'cc': '<!(cd <(DEPTH) && pwd -P)/<(make_clang_dir)/bin/clang',
- 'cxx': '<!(cd <(DEPTH) && pwd -P)/<(make_clang_dir)/bin/clang++',
+ 'cc': '<(clang_absolute_path)',
+ 'cxx': '<(clang++_absolute_path)',
+ }],
+ # When building with a custom clang, CC/CXX must be overridden via GYP
+ # variables.
+ ['instrumented_libraries_cc!=""', {
+ 'cc': '<(instrumented_libraries_cc)',
+ }],
+ ['instrumented_libraries_cxx!=""', {
+ 'cxx': '<(instrumented_libraries_cxx)',
}],
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698