Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1037693003: Disable Screen Orientation API locking ability for WebView. (Closed)

Created:
5 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 9 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Screen Orientation API locking ability for WebView. This CL is adding a content switch that is used by WebView to not create a ScreenOrientationDelegate which will prevent locking to work on WebView and will correctly return that locking isn't supported to Javascript. BUG=466080 Committed: https://crrev.com/8ded9764c2691fc4682c6640beb410bebdc6b35e Cr-Commit-Position: refs/heads/master@{#322404}

Patch Set 1 #

Patch Set 2 : with tests #

Patch Set 3 : compile #

Patch Set 4 : add missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/screen_orientation/screen_orientation_browsertest.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/screen_orientation/screen_orientation_lock_disabled.html View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Torne
lgtm. tested this on a webview build and the API now correctly reports not supported.
5 years, 9 months ago (2015-03-25 16:16:41 UTC) #2
mlamouri (slow - plz ping)
Jochen, this is a M42 stable blocker for WebView.
5 years, 9 months ago (2015-03-25 16:39:04 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-26 15:33:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037693003/60001
5 years, 9 months ago (2015-03-26 15:52:09 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-26 17:06:36 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 17:07:18 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8ded9764c2691fc4682c6640beb410bebdc6b35e
Cr-Commit-Position: refs/heads/master@{#322404}

Powered by Google App Engine
This is Rietveld 408576698