Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1037653004: Revert of Make the canvas draw looper setup update the canvas save count (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
Kimmo Kinnunen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make the canvas draw looper setup update the canvas save count (patchset #1 id:1 of https://codereview.chromium.org/1034033004/) Reason for revert: makes internalSave and internalSaveLayer inconsistent. Need to find a different solution. Original issue's description: > Make the canvas draw looper setup update the canvas save count > > Image filter in a paint would leave save count in wrong state > for normal draws. This could be observed through the canvas > references during the draw call. An example of this is > inspecting the canvas during a draw looper. > > patch from issue 993863002 at patchset 20001 (http://crrev.com/993863002#ps20001) > > BUG=skia: > TBR=kkinnunen@nvidia.com > > Committed: https://skia.googlesource.com/skia/+/fd3a91e1fc4de69611b5297f624a1cd65db4ced1 TBR=kkinnunen@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a644116c3375b12c642d1b51ee1e5cf4a22c1f5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -98 lines) Patch
M gyp/tests.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 5 chunks +3 lines, -4 lines 0 comments Download
D tests/DrawLooperTest.cpp View 1 chunk +0 lines, -92 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
Created Revert of Make the canvas draw looper setup update the canvas save count
5 years, 9 months ago (2015-03-26 20:39:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037653004/1
5 years, 9 months ago (2015-03-26 20:40:04 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 20:40:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a644116c3375b12c642d1b51ee1e5cf4a22c1f5b

Powered by Google App Engine
This is Rietveld 408576698