Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1037643002: Land Recent QUIC Changes until 03/22/2015. (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes until 03/22/2015. Populate slowstart numbers in stats. Merge internal change: 89048638 https://codereview.chromium.org/1030083002/ Add a QUIC connection option(BWMX) to resume to the max bandwidth instead of the last. Merge internal change: 89046643 https://codereview.chromium.org/1037633002/ Populate RTT info in TransportConnectionStats. Moved RttStatsPeer class into a separate file. Merge internal change: 89043159 https://codereview.chromium.org/1009633003/ Deprecate FLAGS_quic_enable_bandwidth_resumption_experiment. Merge internal change: 89021133 https://codereview.chromium.org/1032483003/ Add an extra newline after "Response:" in quic_client's output. Merge internal change: 88898832 https://codereview.chromium.org/1019793009/ QUIC - small formatting changes to keep code in sync with internal source. Merge internal change: 88795283 https://codereview.chromium.org/1037623002/ Low-impact. Dispatcher now uses QuicServerSession, not QuicSession This is a preparatory step for a group of upcoming changes with regards to Stateless Rejects. For stateless rejects, we'd like the dispatcher to access QuicServerSession server-specific information within the session. In order to do that, we need the dispatcher to contain a QuicServerSession object, rather than just a generic QuicSession object. Merge internal change: 88758328 https://codereview.chromium.org/1028633006/ Limit QUIC's send algorithm max CWND by the peer's receive buffer and disable usage of the receive buffer in QuicSentPacketManager. Flag protected by FLAGS_quic_limit_max_cwnd_to_receive_buffer. Merge internal change: 88747441 https://codereview.chromium.org/1023203004/ Improve tests. Correct things clang_tidy complains about. Make QuicTimeWaitListManager::AddConnectionIdToTimeWait virtual so it can be mocked. Correct things clang_tidy complains about. Make a method virtual so it can be mocked. Merge internal change: 88744988 https://codereview.chromium.org/1029463003/ R=rch@chromium.org Committed: https://crrev.com/b346cb02e18a65ac067d7e1bb78529d1f35cc44d Cr-Commit-Position: refs/heads/master@{#322215}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : deleted duplicated using statements in net/tools/quic/test_tools/quic_test_utils.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -162 lines) Patch
M net/net.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M net/quic/congestion_control/rtt_stats_test.cc View 2 chunks +1 line, -11 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 2 chunks +6 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender.cc View 4 chunks +14 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc View 6 chunks +25 lines, -20 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 4 chunks +14 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_connection.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M net/quic/quic_connection_stats.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_dispatcher.h View 5 chunks +10 lines, -9 lines 0 comments Download
M net/quic/quic_dispatcher.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_flags.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 4 chunks +11 lines, -4 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 4 chunks +14 lines, -2 lines 0 comments Download
M net/quic/quic_server_session.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M net/quic/quic_time_wait_list_manager.h View 3 chunks +11 lines, -9 lines 0 comments Download
M net/quic/quic_time_wait_list_manager.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 3 chunks +6 lines, -3 lines 0 comments Download
A net/quic/test_tools/rtt_stats_peer.h View 1 chunk +31 lines, -0 lines 0 comments Download
A net/quic/test_tools/rtt_stats_peer.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 5 chunks +10 lines, -9 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 11 chunks +45 lines, -29 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 1 chunk +4 lines, -5 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ramant (doing other things)
5 years, 9 months ago (2015-03-25 02:44:41 UTC) #1
ramant (doing other things)
Hi Ryan, Have merged all changes until UTC Thu night. Stopped at your changes to ...
5 years, 9 months ago (2015-03-25 02:48:37 UTC) #2
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-25 07:05:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037643002/40001
5 years, 9 months ago (2015-03-25 17:46:41 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-25 19:50:17 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 19:51:21 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b346cb02e18a65ac067d7e1bb78529d1f35cc44d
Cr-Commit-Position: refs/heads/master@{#322215}

Powered by Google App Engine
This is Rietveld 408576698