Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: net/quic/congestion_control/tcp_cubic_sender_test.cc

Issue 1037633002: Add a QUIC connection option(BWMX) to resume to the max bandwidth (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Populate_RTT_info_89043159
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/congestion_control/tcp_cubic_sender.cc ('k') | net/quic/crypto/crypto_protocol.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/congestion_control/tcp_cubic_sender_test.cc
diff --git a/net/quic/congestion_control/tcp_cubic_sender_test.cc b/net/quic/congestion_control/tcp_cubic_sender_test.cc
index 296350aab91d4bafae9523413a279ecf517bd545..fd30ef03caf5e736764c90187f856059ed1cf423 100644
--- a/net/quic/congestion_control/tcp_cubic_sender_test.cc
+++ b/net/quic/congestion_control/tcp_cubic_sender_test.cc
@@ -712,26 +712,33 @@ TEST_F(TcpCubicSenderTest, BandwidthResumption) {
// Ensure that an old estimate is not used for bandwidth resumption.
cached_network_params.set_timestamp(clock_.WallNow().ToUNIXSeconds() -
(kNumSecondsPerHour + 1));
- EXPECT_FALSE(sender_->ResumeConnectionState(cached_network_params));
+ EXPECT_FALSE(sender_->ResumeConnectionState(cached_network_params, false));
EXPECT_EQ(10u, sender_->congestion_window());
// If the estimate is new enough, make sure it is used.
cached_network_params.set_timestamp(clock_.WallNow().ToUNIXSeconds() -
(kNumSecondsPerHour - 1));
- EXPECT_TRUE(sender_->ResumeConnectionState(cached_network_params));
+ EXPECT_TRUE(sender_->ResumeConnectionState(cached_network_params, false));
EXPECT_EQ(kNumberOfPackets, sender_->congestion_window());
// Resumed CWND is limited to be in a sensible range.
cached_network_params.set_bandwidth_estimate_bytes_per_second(
(kMaxTcpCongestionWindow + 1) * kMaxPacketSize);
- EXPECT_TRUE(sender_->ResumeConnectionState(cached_network_params));
+ EXPECT_TRUE(sender_->ResumeConnectionState(cached_network_params, false));
EXPECT_EQ(kMaxTcpCongestionWindow, sender_->congestion_window());
cached_network_params.set_bandwidth_estimate_bytes_per_second(
(kMinCongestionWindowForBandwidthResumption - 1) * kMaxPacketSize);
- EXPECT_TRUE(sender_->ResumeConnectionState(cached_network_params));
+ EXPECT_TRUE(sender_->ResumeConnectionState(cached_network_params, false));
EXPECT_EQ(kMinCongestionWindowForBandwidthResumption,
sender_->congestion_window());
+
+ // Resume to the max value.
+ cached_network_params.set_max_bandwidth_estimate_bytes_per_second(
+ (kMinCongestionWindowForBandwidthResumption + 10) * kDefaultTCPMSS);
+ EXPECT_TRUE(sender_->ResumeConnectionState(cached_network_params, true));
+ EXPECT_EQ((kMinCongestionWindowForBandwidthResumption + 10) * kDefaultTCPMSS,
+ sender_->GetCongestionWindow());
}
} // namespace test
« no previous file with comments | « net/quic/congestion_control/tcp_cubic_sender.cc ('k') | net/quic/crypto/crypto_protocol.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698