Issue 103763002: Do not make a subclass of Text only to disable selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 103763002: Do not make a subclass of Text only to disable selection. (Closed)

Created:
7 years ago by tkent

Modified:
7 years ago

Reviewers:
esprehn

CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Do not make a subclass of Text only to disable selection. We can avoid text selection by adding -webkit-user-select:none to button input elements. We udpate some rendering tests because of slight text color differences and margin selection paint difference. They are acceptable because they are very minor differences. BUG=265699 TEST=Covered by existing tests. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163162

Patch Set 1 #

Patch Set 2 : Remove #include RenderTextFragment.h #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -24 lines)			Patch
M	LayoutTests/TestExpectations	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	LayoutTests/platform/mac/editing/selection/3690703-2-expected.png	View		Binary file		0 comments	Download
M	LayoutTests/platform/mac/editing/selection/3690703-expected.png	View		Binary file		0 comments	Download
M	LayoutTests/platform/mac/editing/selection/3690719-expected.png	View		Binary file		0 comments	Download
M	LayoutTests/platform/mac/editing/selection/selection-button-text-expected.png	View		Binary file		0 comments	Download
M	Source/core/css/html.css	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/Text.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/forms/BaseButtonInputType.cpp	View	1	1 chunk	+1 line, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

esprehn

Crazy, I tried this once and it didn't work. See https://codereview.chromium.org/21182003/ Perhaps it was because ...

7 years ago (2013-12-04 06:41:47 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/103763002/20001

7 years ago (2013-12-04 08:27:57 UTC) #3

Message was sent while issue was closed.

Change committed as 163162

Expand Messages | Collapse Messages