Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: remoting/remoting_webapp.gypi

Issue 1037613002: Rework how remoting JS compilation GYP works. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/remoting_webapp.gypi
diff --git a/remoting/remoting_webapp.gypi b/remoting/remoting_webapp.gypi
index d197e412711c5f76a9a715b8c42d0de1fadd0e13..7222c98313c2519f1b8ea537cba7a94dc313544d 100644
--- a/remoting/remoting_webapp.gypi
+++ b/remoting/remoting_webapp.gypi
@@ -22,71 +22,7 @@
],
'conditions': [
['run_jscompile != 0', {
- 'variables': {
- 'success_stamp': '<(PRODUCT_DIR)/<(_target_name)_jscompile.stamp',
- 'success_stamp_bt': '<(PRODUCT_DIR)/<(_target_name)_bt_jscompile.stamp',
- 'success_stamp_ut': '<(PRODUCT_DIR)/<(_target_name)_ut_jscompile.stamp',
- },
- 'actions': [
- {
- 'action_name': 'Verify remoting webapp',
- 'inputs': [
- '<@(remoting_webapp_crd_js_files)',
- '<@(remoting_webapp_js_proto_files)',
- ],
- 'outputs': [
- '<(success_stamp)',
- ],
- 'action': [
- 'python', '../third_party/closure_compiler/checker.py',
- '--strict',
- '--no-single-file',
- '--success-stamp', '<(success_stamp)',
- '<@(remoting_webapp_crd_js_files)',
- '<@(remoting_webapp_js_proto_files)',
- ],
- },
- {
- 'action_name': 'Verify remoting webapp with browsertests',
- 'inputs': [
- '<@(remoting_webapp_crd_js_files)',
- '<@(remoting_webapp_browsertest_all_js_files)',
- '<@(remoting_webapp_browsertest_js_proto_files)',
- ],
- 'outputs': [
- '<(success_stamp_bt)',
- ],
- 'action': [
- 'python', '../third_party/closure_compiler/checker.py',
- '--strict',
- '--no-single-file',
- '--success-stamp', '<(success_stamp_bt)',
- '<@(remoting_webapp_crd_js_files)',
- '<@(remoting_webapp_browsertest_all_js_files)',
- '<@(remoting_webapp_browsertest_js_proto_files)',
- ],
- },
- {
- 'action_name': 'Verify remoting webapp unittests',
- 'inputs': [
- '<@(remoting_webapp_crd_js_files)',
- '<@(remoting_webapp_unittests_all_js_files)',
- '<@(remoting_webapp_unittests_js_proto_files)',
- ],
- 'outputs': [
- '<(success_stamp_ut)',
- ],
- 'action': [
- 'python', '../third_party/closure_compiler/checker.py',
- '--strict',
- '--no-single-file',
- '--success-stamp', '<(success_stamp_ut)',
- '<@(remoting_webapp_crd_js_files)',
- '<@(remoting_webapp_unittests_all_js_files)',
- '<@(remoting_webapp_unittests_js_proto_files)',
- ],
- },
- ], # actions
+ 'includes': ['remoting_webapp_compile.gypi'],
}],
],
'actions': [

Powered by Google App Engine
This is Rietveld 408576698