Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1037613002: Rework how remoting JS compilation GYP works. (Closed)

Created:
5 years, 9 months ago by Dan Beam
Modified:
5 years, 8 months ago
Reviewers:
Jamie
CC:
chromium-reviews, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rework how remoting JS compilation GYP works. There was an unfortunate bug that swallowed Java stacks. Issues were discovered when Java stacks started surfacing: https://codereview.chromium.org/476453002/ So change the way remoting is built. It doesn't need to be built on all bots by default: they have undefined Java versions and likely weren't working before (and shouldn't differ). Instead, run when run_jscompile=1 is defined in GYP: export GYP_DEFINES=run_jscompile=1 && build/gyp_chromium # or add in ~/.gyp/includes.gypi or $SRC/../chromium.gyp_env # or build/gyp_chromium -Drun_jscompile=1 and on the Closure Compilation Linux FYI bot: http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux This also fixes some GYP inputs problems (if I changed compile_js.gypi or other things in remoting/ ninja wouldn't rebuild anything). R=jamiewalch@chromium.org BUG=none TEST=green bots, remoting runs on Closure Compliation Linux FYI bot Committed: https://crrev.com/b59fe188aa76f3c18a71427c5e655aa609d7c7bd Cr-Commit-Position: refs/heads/master@{#322193}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -76 lines) Patch
M remoting/remoting_options.gypi View 2 chunks +1 line, -10 lines 0 comments Download
M remoting/remoting_webapp.gypi View 1 chunk +1 line, -65 lines 0 comments Download
A remoting/remoting_webapp_compile.gypi View 1 chunk +80 lines, -0 lines 0 comments Download
M third_party/closure_compiler/compile_js.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/closure_compiler/compiled_resources.gyp View 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 11 (3 generated)
Dan Beam
https://codereview.chromium.org/1037613002/diff/1/third_party/closure_compiler/compiled_resources.gyp File third_party/closure_compiler/compiled_resources.gyp (right): https://codereview.chromium.org/1037613002/diff/1/third_party/closure_compiler/compiled_resources.gyp#newcode40 third_party/closure_compiler/compiled_resources.gyp:40: '../../remoting/remoting_webapp_compile.gypi', this means it'll run on the bots (see: ...
5 years, 9 months ago (2015-03-25 00:47:27 UTC) #1
Jamie
lgtm
5 years, 9 months ago (2015-03-25 01:07:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037613002/1
5 years, 9 months ago (2015-03-25 02:38:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/40013)
5 years, 9 months ago (2015-03-25 04:35:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037613002/1
5 years, 9 months ago (2015-03-25 17:43:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 18:26:00 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b59fe188aa76f3c18a71427c5e655aa609d7c7bd Cr-Commit-Position: refs/heads/master@{#322193}
5 years, 9 months ago (2015-03-25 18:26:54 UTC) #10
kelvinp
5 years, 8 months ago (2015-03-31 23:30:53 UTC) #11
Message was sent while issue was closed.
On 2015/03/25 18:26:54, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/b59fe188aa76f3c18a71427c5e655aa609d7c7bd
> Cr-Commit-Position: refs/heads/master@{#322193}

Hi Dan, 

Is the closure compiler FYI bots part of CQ?
If not, doesn't mean after your change, compilation errors in remoting won't be
caught by try bots before it got landed?

Kelvin

Powered by Google App Engine
This is Rietveld 408576698