Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1037573003: enhancedBookmarks iOS changes. (Closed)

Created:
5 years, 9 months ago by noyau (Ping after 24h)
Modified:
5 years, 9 months ago
Reviewers:
Mike Wittman, danduong
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, browser-components-watch_chromium.org, danduong
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

enhancedBookmarks iOS changes. Fixes for iOS compile. BUG=None Committed: https://crrev.com/8e25cde9e9b759c904c4e592ecc7b72aa4be972f Cr-Commit-Position: refs/heads/master@{#322526}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Feedback. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M chrome/browser/bookmarks/enhanced_bookmarks_features.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/enhanced_bookmarks_features.cc View 1 2 chunks +21 lines, -15 lines 1 comment Download

Messages

Total messages: 12 (4 generated)
noyau (Ping after 24h)
5 years, 9 months ago (2015-03-25 14:08:17 UTC) #2
noyau (Ping after 24h)
[+cc danduong, FYI]
5 years, 9 months ago (2015-03-25 14:09:31 UTC) #3
Mike Wittman
Can you gate the newly-enabled code on defined(OS_ANDROID) || defined(OS_IOS) instead? IsEnhancedBookmarksEnabled() isn't used on ...
5 years, 9 months ago (2015-03-25 17:52:58 UTC) #4
noyau (Ping after 24h)
PTAL. https://codereview.chromium.org/1037573003/diff/1/chrome/browser/bookmarks/enhanced_bookmarks_features.cc File chrome/browser/bookmarks/enhanced_bookmarks_features.cc (right): https://codereview.chromium.org/1037573003/diff/1/chrome/browser/bookmarks/enhanced_bookmarks_features.cc#newcode24 chrome/browser/bookmarks/enhanced_bookmarks_features.cc:24: bool GetBookmarksExperimentExtensionID(std::string* extension_id) { On 2015/03/25 17:52:58, Mike ...
5 years, 9 months ago (2015-03-26 10:19:41 UTC) #7
Mike Wittman
lgtm https://codereview.chromium.org/1037573003/diff/60001/chrome/browser/bookmarks/enhanced_bookmarks_features.cc File chrome/browser/bookmarks/enhanced_bookmarks_features.cc (right): https://codereview.chromium.org/1037573003/diff/60001/chrome/browser/bookmarks/enhanced_bookmarks_features.cc#newcode65 chrome/browser/bookmarks/enhanced_bookmarks_features.cc:65: // "0" - user opted out. "1" is ...
5 years, 9 months ago (2015-03-26 16:35:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037573003/60001
5 years, 9 months ago (2015-03-27 00:59:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 9 months ago (2015-03-27 04:00:12 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 04:00:54 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8e25cde9e9b759c904c4e592ecc7b72aa4be972f
Cr-Commit-Position: refs/heads/master@{#322526}

Powered by Google App Engine
This is Rietveld 408576698