Move early outs to the top of View::Paint and OnPaintLayer

Move early outs to the top of View::Paint and OnPaintLayer

This makes the CullSet check into an early out instead of
an if-block wrapping a whole function.

It also moves the |visible_| early out to the same place
from PaintCommon(). This hints at combining Paint() and
PaintCommont().

This also moves the |visible_| early out to the other caller
of PaintCommon() which is OnPaintLayer(), and can early
out before doing the solid color clear.

BUG=466426
Committed: https://crrev.com/dfc1488dea1301d4656e2a5c73b586a5058c4ce6
Cr-Commit-Position: refs/heads/master@{#322220}

[danakj, 2015-03-24 21:02:22]

Patchset #2 (id:20001) has been deleted

[danakj, 2015-03-24 21:04:12]

Patchset #2 (id:40001) has been deleted

[danakj, 2015-03-24 21:06:34]

danakj@chromium.org changed reviewers:
+ sky@chromium.org

[danakj, 2015-03-24 21:07:00]

This patch looks big due to moving the if() { .... } to a if(!) return; So doing
it as a separate CL.

[sky, 2015-03-24 22:11:22]

https://codereview.chromium.org/1037513002/diff/60001/ui/views/view.cc
File ui/views/view.cc (right):

https://codereview.chromium.org/1037513002/diff/60001/ui/views/view.cc#newcod...
ui/views/view.cc:1467: if (!visible_)
I'm tempted to say this should be a DCHECK, but it looks like view doesn't
attempt to enforce the layers visibility matches the visibility of this. If we
do end up here, should we at least do 1470? Otherwise won't the layer end up
with garbage?

[danakj, 2015-03-24 22:15:12]

Patchset #3 (id:20002) has been deleted

[danakj, 2015-03-24 22:15:20]

PTAL

https://codereview.chromium.org/1037513002/diff/60001/ui/views/view.cc
File ui/views/view.cc (right):

https://codereview.chromium.org/1037513002/diff/60001/ui/views/view.cc#newcod...
ui/views/view.cc:1467: if (!visible_)
On 2015/03/24 22:11:21, sky wrote:
> I'm tempted to say this should be a DCHECK, but it looks like view doesn't
> attempt to enforce the layers visibility matches the visibility of this. If we
> do end up here, should we at least do 1470? Otherwise won't the layer end up
> with garbage?

It would get garbage if it claimed to be opaque "set_fills_bounds_opaquely", and
would get transparent otherwise. Ya doing the clear seems fine then, it matches
the same conditions.

[sky, 2015-03-24 22:27:51]

LGTM

[danakj, 2015-03-24 22:30:09]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-03-24 22:30:10]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1037513002/#ps110001
(title: "paint-visible-earlyouts: rebase")

[commit-bot: I haz the power, 2015-03-24 22:31:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1037513002/110001

[danakj, 2015-03-24 22:31:15]

Patchset #4 (id:110001) has been deleted

[danakj, 2015-03-24 22:31:20]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2015-03-24 22:31:46]

Oops, I dropped the early-out change for the cullset in that last patchset, put
it back.

[danakj, 2015-03-24 22:32:05]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-03-24 22:32:06]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1037513002/#ps130001
(title: "paint-visible-earlyouts: rebase")

[commit-bot: I haz the power, 2015-03-24 22:32:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1037513002/130001

[commit-bot: I haz the power, 2015-03-25 04:01:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-25 04:01:24]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2015-03-25 18:35:15]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2015-03-25 18:36:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1037513002/130001

[commit-bot: I haz the power, 2015-03-25 19:55:29]

Committed patchset #4 (id:130001)

[commit-bot: I haz the power, 2015-03-25 19:56:11]

Patchset 4 (id:??) landed as
https://crrev.com/dfc1488dea1301d4656e2a5c73b586a5058c4ce6
Cr-Commit-Position: refs/heads/master@{#322220}