Issue 1037483005: Fixed browser options page

Issue 1037483005: Fixed browser options page (Closed)

Created:
5 years, 9 months ago by François Beaufort

Modified:
5 years, 9 months ago

Reviewers:
stevenjb, Steven Holte

CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fixed browser options page Before/Now comparison: http://imgur.com/a/4Nivx BUG=467790 Committed: https://crrev.com/fc16bb92a76642191940441db1bd9b99b3f7ec46 Cr-Commit-Position: refs/heads/master@{#322186}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/options/browser_options.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (3 generated)

François Beaufort

Hello Steven, Do you mind reviewing this simple fix which causes following options to be ...

5 years, 9 months ago (2015-03-25 13:35:32 UTC) #2

stevenjb

Nice catch, LGTM. This was introduced in https://codereview.chromium.org/886523003/ +holte@ in case it gets filed as ...

5 years, 9 months ago (2015-03-25 15:57:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037483005/20001

5 years, 9 months ago (2015-03-25 16:00:23 UTC) #6

commit-bot: I haz the power

5 years, 9 months ago (2015-03-25 17:27:05 UTC) #8

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/fc16bb92a76642191940441db1bd9b99b3f7ec46
Cr-Commit-Position: refs/heads/master@{#322186}