Telemetry benchmark key_desktop_move_pages.

Telemetry benchmark key_desktop_move_pages.

This CL adds new benchmark to run drag gestures on gmail and maps page.
These pages are moved from top_25_smooth page set since this is desktop
specific. Please refer to crrev.com/985603003 and crrev.com/955653003
for motivation.

BUG=457148
BUG=464685
Committed: https://crrev.com/c3cec45c63b4fe896ee97eb391dd6bae7733017b
Cr-Commit-Position: refs/heads/master@{#322557}

[ssid, 2015-03-25 12:47:28]

ssid@chromium.org changed reviewers:
+ picksi@chromium.org, skyostil@chromium.org

[ssid, 2015-03-25 12:47:29]

Adding new benchmark for the telemetry pages, since top_25_smooth should not
have desktop specific pages.

[picksi, 2015-03-25 14:13:04]

picksi@google.com changed reviewers:
+ picksi@google.com

[picksi, 2015-03-25 14:13:05]

Looks good. One comment as we discussed off-line.

https://codereview.chromium.org/1037483004/diff/1/tools/perf/page_sets/key_de...
File tools/perf/page_sets/key_desktop_move_cases.py (right):

https://codereview.chromium.org/1037483004/diff/1/tools/perf/page_sets/key_de...
tools/perf/page_sets/key_desktop_move_cases.py:79: return scrollbar_mid_x,
scrollbar_start_mid_y, scrollbar_end_mid_y
As per our conversation: The purpose of the scroll bar calculations above are
not clear. If you are able to break these down a little and explain what each
result is that would be helpful; I think you have simplified the maths too far!

https://codereview.chromium.org/1037483004/diff/1/tools/perf/page_sets/key_de...
tools/perf/page_sets/key_desktop_move_cases.py:99: for _ in range(3):
I didn't know you could do this! I assume this is an anonymous loop?

[Sami, 2015-03-25 20:55:01]

lgtm since you're just moving code around, but I agree that the part Simon
pointed out could be cleaned up a little.

https://codereview.chromium.org/1037483004/diff/1/tools/perf/page_sets/key_de...
File tools/perf/page_sets/key_desktop_move_cases.py (right):

https://codereview.chromium.org/1037483004/diff/1/tools/perf/page_sets/key_de...
tools/perf/page_sets/key_desktop_move_cases.py:13: credentials_path =
'data/credentials.json')
nit: no spaces around the '='.

[ssid, 2015-03-26 19:25:57]

Patchset #2 (id:20001) has been deleted

[ssid, 2015-03-27 10:43:05]

Simon, made changes, PTAL.

https://codereview.chromium.org/1037483004/diff/1/tools/perf/page_sets/key_de...
File tools/perf/page_sets/key_desktop_move_cases.py (right):

https://codereview.chromium.org/1037483004/diff/1/tools/perf/page_sets/key_de...
tools/perf/page_sets/key_desktop_move_cases.py:13: credentials_path =
'data/credentials.json')
On 2015/03/25 20:55:00, Sami (slow -- traveling) wrote:
> nit: no spaces around the '='.

Done.

https://codereview.chromium.org/1037483004/diff/1/tools/perf/page_sets/key_de...
tools/perf/page_sets/key_desktop_move_cases.py:79: return scrollbar_mid_x,
scrollbar_start_mid_y, scrollbar_end_mid_y
On 2015/03/25 14:13:05, picksi wrote:
> As per our conversation: The purpose of the scroll bar calculations above are
> not clear. If you are able to break these down a little and explain what each
> result is that would be helpful; I think you have simplified the maths too
far!

Done.

[ssid, 2015-03-27 10:59:10]

The CQ bit was checked by ssid@chromium.org

[ssid, 2015-03-27 10:59:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1037483004/#ps60001
(title: "Added comments.")

[commit-bot: I haz the power, 2015-03-27 10:59:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1037483004/60001

[commit-bot: I haz the power, 2015-03-27 11:56:58]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-03-27 11:57:40]

Patchset 3 (id:??) landed as
https://crrev.com/c3cec45c63b4fe896ee97eb391dd6bae7733017b
Cr-Commit-Position: refs/heads/master@{#322557}