Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: content/browser/presentation/presentation_service_impl.h

Issue 1037483003: [PresentationAPI] Implementing send() from WebPresentationClient to the PresentationService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added queuing mechanism for postMessage requests. (WIP) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/presentation/presentation_service_impl.h
diff --git a/content/browser/presentation/presentation_service_impl.h b/content/browser/presentation/presentation_service_impl.h
index 104b3ae9b92b5d79fb731a844629e0e9f1f0d941..8b77320929ab99f128b0c6d8fdd25328837df7e5 100644
--- a/content/browser/presentation/presentation_service_impl.h
+++ b/content/browser/presentation/presentation_service_impl.h
@@ -163,6 +163,10 @@ class CONTENT_EXPORT PresentationServiceImpl
const mojo::String& presentation_url,
const mojo::String& presentation_id,
const NewSessionMojoCallback& callback) override;
+ void PostMessages(
mark a. foltz 2015/04/02 20:46:26 For all types that can be sent/received, we need t
imcheng 2015/04/02 23:57:24 We must limit the size of the messages. 64k sounds
USE s.singapati at gmail.com 2015/04/07 17:45:16 Acknowledged. Do we want to stop sending messages
+ const mojo::String& presentation_url,
+ const mojo::String& presentation_id,
+ mojo::Array<mojo::String> string_messages) override;
mark a. foltz 2015/04/02 20:46:26 Mojo guarantees FIFO order for messages sent throu
USE s.singapati at gmail.com 2015/04/07 17:45:16 I've created a patch with new queuing approach to
void CloseSession(
const mojo::String& presentation_url,
const mojo::String& presentation_id) override;

Powered by Google App Engine
This is Rietveld 408576698