content/browser/presentation/presentation_service_impl_unittest.cc - Issue 1037483003: [PresentationAPI] Implementing send() from WebPresentationClient to the PresentationService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/presentation/presentation_service_impl_unittest.cc

Issue 1037483003: [PresentationAPI] Implementing send() from WebPresentationClient to the PresentationService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated callback handling, message invalidation and and sending generic message struct. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/presentation/presentation_service_impl.cc ('k') | content/common/presentation/presentation_message.h » ('j') | content/common/presentation/presentation_message.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/presentation/presentation_service_impl_unittest.cc

diff --git a/content/browser/presentation/presentation_service_impl_unittest.cc b/content/browser/presentation/presentation_service_impl_unittest.cc

index 1f7f758405395f55c0f519d7aeba2e52f4302d3e..958cac9f10ffeecf03ce0693cf284992bf380640 100644

--- a/content/browser/presentation/presentation_service_impl_unittest.cc

+++ b/content/browser/presentation/presentation_service_impl_unittest.cc

@@ -184,6 +184,11 @@ class PresentationServiceImplTest : public RenderViewHostImplTestHarness {

run_loop_quit_closure_.Run();

}

+ void ExpectSendMessageMojoCallback() {

+ if (!run_loop_quit_closure_.is_null())

+ run_loop_quit_closure_.Run();

+ }

MockPresentationServiceDelegate mock_delegate_;

scoped_ptr<PresentationServiceImpl> service_impl_;

mojo::InterfacePtr<presentation::PresentationService> service_ptr_;

@@ -581,4 +586,8 @@ TEST_F(PresentationServiceImplTest, StartSessionInProgress) {

SaveQuitClosureAndRunLoop();

}

+/*

+ * TODO(s.singapati): Add testcase for SendMessage()

+ */

} // namespace content