content/common/presentation/presentation_service.mojom - Issue 1037483003: [PresentationAPI] Implementing send() from WebPresentationClient to the PresentationService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/presentation/presentation_service.mojom

Issue 1037483003: [PresentationAPI] Implementing send() from WebPresentationClient to the PresentationService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Extended SendStringMessage() to delegate, Added unit test & other fixes. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/presentation/presentation_service_impl.cc ('K') | « content/browser/presentation/presentation_service_impl_unittest.cc ('k') | content/public/browser/presentation_service_delegate.h » ('j') | content/renderer/presentation/presentation_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/presentation/presentation_service.mojom

diff --git a/content/common/presentation/presentation_service.mojom b/content/common/presentation/presentation_service.mojom

index 36756e23a080698ec63f93627b099bba23d9750e..7ccd96894867e02f3764f8926d063156e7daf6d8 100644

--- a/content/common/presentation/presentation_service.mojom

+++ b/content/common/presentation/presentation_service.mojom

@@ -74,6 +74,13 @@ interface PresentationService {

JoinSession(string presentation_url, string? presentation_id)

=> (PresentationSessionInfo? sessionInfo, PresentationError? error);

+ // Called when send(String) is called by the frame. The result callback is

+ // to get notified that message has been received and ready for next one.

+ SendStringMessage(

+ string presentation_url,

+ string presentation_id,

+ string message) => ();

// Called when closeSession() is called by the frame.

CloseSession(string presentation_url, string presentation_id);