[PresentationAPI] Implementing send() from WebPresentationClient to the PresentationService.

content/public/browser/presentation_service_delegate.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_PRESENTATION_SERVICE_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_PRESENTATION_SERVICE_DELEGATE_H_
 
 #include "base/callback.h"
 #include "content/common/content_export.h"
+#include "content/public/browser/presentation_message.h"
 #include "content/public/browser/presentation_session.h"
 
 namespace content {
 
 class PresentationScreenAvailabilityListener;
 
 // An interface implemented by embedders to handle presentation API calls
 // forwarded from PresentationServiceImpl.
 class CONTENT_EXPORT PresentationServiceDelegate {
  public:
@@ skipping 11 matching lines @@
         const PresentationSessionInfo& session) = 0;
 
    protected:
     virtual ~Observer() {}
   };
 
   using PresentationSessionSuccessCallback =
       base::Callback<void(const PresentationSessionInfo&)>;
   using PresentationSessionErrorCallback =
       base::Callback<void(const PresentationError&)>;
+  using SendMessageCallback = base::Callback<void()>;

[imcheng (use chromium acct), 2015/04/30 20:11:30]

using SendMessageCallback = base::Closure;

[USE s.singapati at gmail.com, 2015/05/04 16:40:28]

Done.

 
   virtual ~PresentationServiceDelegate() {}
 
   // Registers an observer associated with frame with |render_process_id|
   // and |render_frame_id| with this class to listen for updates.
   // This class does not own the observer.
   // It is an error to add an observer if there is already an observer for that
   // frame.
   virtual void AddObserver(int render_process_id,
                            int render_frame_id,
@@ skipping 71 matching lines @@
   // |success_cb|: Invoked with session info, if presentation session joined
   // successfully.
   // |error_cb|: Invoked with error reason, if joining failed.
   virtual void JoinSession(
       int render_process_id,
       int render_frame_id,
       const std::string& presentation_url,
       const std::string& presentation_id,
       const PresentationSessionSuccessCallback& success_cb,
       const PresentationSessionErrorCallback& error_cb) = 0;
+
+  // Sends a message (string or binary data) to a presentation session.
+  // |render_process_id|, |render_frame_id|: ID of originating frame.
+  // |message_request|: Contains Presentation URL, ID and message to be sent
+  // and delegate is responsible for deallocating the message_request.

[imcheng (use chromium acct), 2015/04/30 20:11:30]

Please also document |send_message_cb|.

[USE s.singapati at gmail.com, 2015/05/04 16:40:28]

Done.

+  virtual void SendMessage(
+      int render_process_id,
+      int render_frame_id,
+      PresentationMessageRequest* message_request,

[imcheng (use chromium acct), 2015/04/30 20:11:30]

Can this be a scoped_ptr so it's less error prone to memory leaks? For mocking
it's a bit tricky since gmock doesn't seem to support mocking of move-only
parameters. One way around it is that in the mock delegate class, add a mock
function that takes a PresentationMessageRequest* in the instead (e.g.,
SendMessageRawPtr), and then provide a concrete implementation of SendMessage
that forwards the parameters (but |message_request| as a raw pointer) to
SendMessageRawPtr().

[USE s.singapati at gmail.com, 2015/05/01 10:30:25]

Ok, I will check this one.

[USE s.singapati at gmail.com, 2015/05/04 16:40:28]

sending scoped_ptr to delegate is fine. But mocking in unittest seems to be
tricky as you mentioned. I am still working on this.

[USE s.singapati at gmail.com, 2015/05/05 14:26:36]

Done.

+      const SendMessageCallback& send_message_cb) = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_PRESENTATION_SERVICE_DELEGATE_H_