[PresentationAPI] Implementing send() from WebPresentationClient to the PresentationService.

content/common/presentation/presentation_message.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_COMMON_PRESENTATION_PRESENTATION_MESSAGE_H_

[imcheng, 2015/04/22 20:12:02]

This file and the .cc file should go under content/public/browser. That way
PresentationServiceDelegate will be able to legally include this file.

[USE s.singapati at gmail.com, 2015/04/23 12:39:23]

presentation_message.h needs to be included both in the PresentationDispatcher
and PresentationServiceDelegate. If this go under content/public/browser,
including from presentation_dispatcher.h fails.

Moving presentation_message.h/.cc into "content/public/common/" works for
PresentationDispatcher & PresentationServiceDelegate. BUT there is Illegal
include problem in including
"content/common/presentation/presentation_service.mojom.h" in the
presentation_message.h.

would it need to move presentation_service.mojom appropriately? 

+#define CONTENT_COMMON_PRESENTATION_PRESENTATION_MESSAGE_H_
+
+#include <string>
+#include <vector>
+
+#include "content/common/content_export.h"
+#include "content/common/presentation/presentation_service.mojom.h"
+
+namespace content {
+
+enum CONTENT_EXPORT PresentationMessageType {
+  TEXT,
+  ARRAY_BUFFER,
+};
+
+// Message to be exchanged between presentation sessions.
+struct CONTENT_EXPORT MessageRequest {

[imcheng, 2015/04/22 20:12:02]

Please be more specific in the class name. Perhaps PresentationMessageRequest?
Also, more documentation would be good.

[USE s.singapati at gmail.com, 2015/04/27 19:28:56]

In mojom file: struct "SessionMessage" would be better naming i think. so this
would be accessed presentation::SessionMessage always. Also this will be used in
onmessage implementation.

Based on that "PresentationSessionMessage" probably the choice in content? 
Or any proposal for naming finalization?

+  MessageRequest(
+      const std::string& presentation_url,
+      const std::string& presentation_id,
+      const std::string& message);
+  MessageRequest(
+      const std::string& presentation_url,
+      const std::string& presentation_id,
+      const std::vector<uint8_t>& data);
+  MessageRequest(presentation::MessageRequestPtr request);
+  ~MessageRequest();
+
+  const std::string presentation_url;
+  const std::string presentation_id;
+  PresentationMessageType type;
+  const std::string message;
+  const std::vector<uint8_t> data;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_COMMON_PRESENTATION_PRESENTATION_MESSAGE_H_