Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1911)

Unified Diff: Source/core/svg/SVGPathConsumer.h

Issue 1037463002: Rework the SVGPathConsumer interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase; FIXME -> TODO. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGPathByteStreamBuilder.cpp ('k') | Source/core/svg/SVGPathParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGPathConsumer.h
diff --git a/Source/core/svg/SVGPathConsumer.h b/Source/core/svg/SVGPathConsumer.h
index ea0bc1ef58bcf17a91daf416f3ecd301fab1ec1b..0327a750a14d02be669487a6cfddc5f697d26a13 100644
--- a/Source/core/svg/SVGPathConsumer.h
+++ b/Source/core/svg/SVGPathConsumer.h
@@ -24,7 +24,6 @@
#ifndef SVGPathConsumer_h
#define SVGPathConsumer_h
-#include "platform/geometry/FloatPoint.h"
#include "platform/heap/Handle.h"
#include "wtf/FastAllocBase.h"
#include "wtf/Noncopyable.h"
@@ -41,6 +40,8 @@ enum PathParsingMode {
UnalteredParsing
};
+struct PathSegmentData;
+
class SVGPathConsumer : public NoBaseWillBeGarbageCollectedFinalized<SVGPathConsumer> {
WTF_MAKE_NONCOPYABLE(SVGPathConsumer); WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(SVGPathConsumer);
public:
@@ -51,19 +52,7 @@ public:
virtual void incrementPathSegmentCount() = 0;
virtual bool continueConsuming() = 0;
- // Used in UnalteredParsing/NormalizedParsing modes.
- virtual void moveTo(const FloatPoint&, PathCoordinateMode) = 0;
- virtual void lineTo(const FloatPoint&, PathCoordinateMode) = 0;
- virtual void curveToCubic(const FloatPoint&, const FloatPoint&, const FloatPoint&, PathCoordinateMode) = 0;
- virtual void closePath() = 0;
-
- // Only used in UnalteredParsing mode.
- virtual void lineToHorizontal(float, PathCoordinateMode) = 0;
- virtual void lineToVertical(float, PathCoordinateMode) = 0;
- virtual void curveToCubicSmooth(const FloatPoint&, const FloatPoint&, PathCoordinateMode) = 0;
- virtual void curveToQuadratic(const FloatPoint&, const FloatPoint&, PathCoordinateMode) = 0;
- virtual void curveToQuadraticSmooth(const FloatPoint&, PathCoordinateMode) = 0;
- virtual void arcTo(float, float, float, bool largeArcFlag, bool sweepFlag, const FloatPoint&, PathCoordinateMode) = 0;
+ virtual void emitSegment(const PathSegmentData&) = 0;
};
} // namespace blink
« no previous file with comments | « Source/core/svg/SVGPathByteStreamBuilder.cpp ('k') | Source/core/svg/SVGPathParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698