Issue 1037443002: Move oknet's read operations to a background thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1037443002: Move oknet's read operations to a background thread (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
ojan

CC:
ojan, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Move oknet's read operations to a background thread The read operation on OkHttp's ResponseBody object is blocking. The thread on which we perform the read is highly contended during initial load. This CL moves the read operation to a background thread, improving startup time for StocksApp by 1s on a Nexus 5. Ideally we would perform an asynchronous read on the stream, but that is not currently possible in OkHttp according to http://stackoverflow.com/questions/29222231/reading-okhttp-responsebody-data-asynchronously R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/46ced9ba693dd4f56d1d44e13e60ea3d66f9f792

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -38 lines)			Patch
	M	sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java	View	1 2	6 chunks	+11 lines, -38 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 9 months ago (2015-03-24 19:44:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
46ced9ba693dd4f56d1d44e13e60ea3d66f9f792 (presubmit successful).