Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1037433002: Avoid evacuation of popular pages. (Closed)

Created:
5 years, 9 months ago by ulan
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid evacuation of popular pages. This breaks the (evacuation -> slots buffer overflow -> abort -> new GC -> evacuation) cycle for popular pages. BUG= Committed: https://crrev.com/63c6f7da348c3356cf6dfd303c84b05f6477e2c2 Cr-Commit-Position: refs/heads/master@{#27868}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M src/heap/mark-compact.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 4 chunks +11 lines, -3 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ulan
PTAL
5 years, 9 months ago (2015-03-24 17:04:29 UTC) #2
Hannes Payer (out of office)
LGTM
5 years, 9 months ago (2015-03-24 17:07:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037433002/40001
5 years, 9 months ago (2015-03-24 17:09:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/2708)
5 years, 9 months ago (2015-03-24 17:11:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037433002/70001
5 years, 8 months ago (2015-04-16 08:01:00 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years, 8 months ago (2015-04-16 08:34:14 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 08:34:29 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/63c6f7da348c3356cf6dfd303c84b05f6477e2c2
Cr-Commit-Position: refs/heads/master@{#27868}

Powered by Google App Engine
This is Rietveld 408576698