Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1037423002: html_viewer: Run with a cookie jar. (Closed)

Created:
5 years, 9 months ago by Elliot Glaysher
Modified:
5 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

html_viewer: Run with a cookie jar. Ever since https://codereview.chromium.org/710803002/, we haven't been exposing a cookie jar or a clipboard to html_viewer. This looks like an accident during refactoring. BUG= Committed: https://crrev.com/617e549ee93838926d8c6a4de9d1f50209be3c7a Cr-Commit-Position: refs/heads/master@{#322676}

Patch Set 1 #

Total comments: 1

Patch Set 2 : virtual -> override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M mojo/services/html_viewer/mojo_blink_platform_impl.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/mojo_blink_platform_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Elliot Glaysher
5 years, 9 months ago (2015-03-27 22:21:27 UTC) #2
sky
LGTM https://codereview.chromium.org/1037423002/diff/1/mojo/services/html_viewer/mojo_blink_platform_impl.h File mojo/services/html_viewer/mojo_blink_platform_impl.h (right): https://codereview.chromium.org/1037423002/diff/1/mojo/services/html_viewer/mojo_blink_platform_impl.h#newcode28 mojo/services/html_viewer/mojo_blink_platform_impl.h:28: virtual blink::WebCookieJar* cookieJar(); nit no virtual, but override.
5 years, 9 months ago (2015-03-27 23:09:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037423002/20001
5 years, 9 months ago (2015-03-27 23:11:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-27 23:36:09 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 23:37:03 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/617e549ee93838926d8c6a4de9d1f50209be3c7a
Cr-Commit-Position: refs/heads/master@{#322676}

Powered by Google App Engine
This is Rietveld 408576698