Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1037403003: [sqlite backport] Fix collation dequoting. (Closed)

Created:
5 years, 9 months ago by Scott Hess - ex-Googler
Modified:
5 years, 9 months ago
Reviewers:
inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

[sqlite backport] Fix collation dequoting. Backport https://www.sqlite.org/src/info/eddc05e7bb31fae7 "Fix a problem causing collation sequence names to be dequoted multiple times under some circumstances." BUG=469082 TBR=inferno@chromium.org Review URL: https://codereview.chromium.org/1022423004 Cr-Commit-Position: refs/heads/master@{#322165} (cherry picked from commit 3e13a01e946b7df16a5b3702ac016b5784945a90) Committed: https://chromium.googlesource.com/chromium/src/+/90856262ae6ae80bd6f478b820515e35c21f094b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -26 lines) Patch
M third_party/sqlite/amalgamation/sqlite3.c View 9 chunks +12 lines, -12 lines 0 comments Download
A third_party/sqlite/patches/0018-backport-Fix-collation-dequoting.patch View 1 chunk +205 lines, -0 lines 0 comments Download
M third_party/sqlite/src/src/expr.c View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/sqlite/src/src/parse.y View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/sqlite/src/src/sqliteInt.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/sqlite/src/src/where.c View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/sqlite/src/test/collate1.test View 2 chunks +56 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037403003/1
5 years, 9 months ago (2015-03-27 22:50:11 UTC) #2
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true in order for the CQ ...
5 years, 9 months ago (2015-03-27 22:50:14 UTC) #4
Scott Hess - ex-Googler
5 years, 9 months ago (2015-03-27 22:54:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
90856262ae6ae80bd6f478b820515e35c21f094b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698