Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Side by Side Diff: mojo/services/html_viewer/ax_provider_impl_unittest.cc

Issue 1037363002: Remove unnecessary 'virtual' annotation from mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolved merge conflicts Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « AUTHORS ('k') | mojo/services/html_viewer/blink_platform_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/services/html_viewer/ax_provider_impl.h" 5 #include "mojo/services/html_viewer/ax_provider_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "gin/public/isolate_holder.h" 9 #include "gin/public/isolate_holder.h"
10 #include "mojo/services/html_viewer/blink_platform_impl.h" 10 #include "mojo/services/html_viewer/blink_platform_impl.h"
(...skipping 15 matching lines...) Expand all
26 using blink::WebViewClient; 26 using blink::WebViewClient;
27 27
28 using mojo::Array; 28 using mojo::Array;
29 using mojo::AxNode; 29 using mojo::AxNode;
30 using mojo::AxNodePtr; 30 using mojo::AxNodePtr;
31 31
32 namespace { 32 namespace {
33 33
34 class TestWebFrameClient : public WebFrameClient { 34 class TestWebFrameClient : public WebFrameClient {
35 public: 35 public:
36 virtual ~TestWebFrameClient() {} 36 ~TestWebFrameClient() override {}
37 virtual void didStopLoading() { base::MessageLoop::current()->Quit(); } 37 void didStopLoading() override { base::MessageLoop::current()->Quit(); }
38 }; 38 };
39 39
40 class TestWebViewClient : public WebViewClient { 40 class TestWebViewClient : public WebViewClient {
41 public: 41 public:
42 virtual bool allowsBrokenNullLayerTreeView() const { return true; } 42 bool allowsBrokenNullLayerTreeView() const override { return true; }
43 virtual ~TestWebViewClient() {} 43 virtual ~TestWebViewClient() {}
44 }; 44 };
45 45
46 class AxProviderImplTest : public testing::Test { 46 class AxProviderImplTest : public testing::Test {
47 public: 47 public:
48 AxProviderImplTest() { 48 AxProviderImplTest() {
49 #if defined(V8_USE_EXTERNAL_STARTUP_DATA) 49 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)
50 gin::IsolateHolder::LoadV8Snapshot(); 50 gin::IsolateHolder::LoadV8Snapshot();
51 #endif 51 #endif
52 blink::initialize(new html_viewer::BlinkPlatformImpl()); 52 blink::initialize(new html_viewer::BlinkPlatformImpl());
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 "", 169 "",
170 "")); 170 ""));
171 } 171 }
172 } 172 }
173 173
174 // TODO(aa): Test bounds. 174 // TODO(aa): Test bounds.
175 // TODO(aa): Test sibling ordering of foo/bar/baz. 175 // TODO(aa): Test sibling ordering of foo/bar/baz.
176 176
177 view->close(); 177 view->close();
178 } 178 }
OLDNEW
« no previous file with comments | « AUTHORS ('k') | mojo/services/html_viewer/blink_platform_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698