| Index: src/x64/full-codegen-x64.cc
|
| diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc
|
| index d8bf19fc111b3c47126ad45dc97812b737feb842..5861327bb59ba1625a723928d5f82c76375115a2 100644
|
| --- a/src/x64/full-codegen-x64.cc
|
| +++ b/src/x64/full-codegen-x64.cc
|
| @@ -1657,16 +1657,8 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
|
|
|
| expr->BuildConstantProperties(isolate());
|
| Handle<FixedArray> constant_properties = expr->constant_properties();
|
| - int flags = expr->fast_elements()
|
| - ? ObjectLiteral::kFastElements
|
| - : ObjectLiteral::kNoFlags;
|
| - flags |= expr->has_function()
|
| - ? ObjectLiteral::kHasFunction
|
| - : ObjectLiteral::kNoFlags;
|
| - int properties_count = constant_properties->length() / 2;
|
| - if (expr->may_store_doubles() || expr->depth() > 1 ||
|
| - masm()->serializer_enabled() || flags != ObjectLiteral::kFastElements ||
|
| - properties_count > FastCloneShallowObjectStub::kMaximumClonedProperties) {
|
| + int flags = expr->ComputeFlags();
|
| + if (MustCreateObjectLiteralWithRuntime(expr)) {
|
| __ movp(rdi, Operand(rbp, JavaScriptFrameConstants::kFunctionOffset));
|
| __ Push(FieldOperand(rdi, JSFunction::kLiteralsOffset));
|
| __ Push(Smi::FromInt(expr->literal_index()));
|
| @@ -1679,7 +1671,7 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
|
| __ Move(rbx, Smi::FromInt(expr->literal_index()));
|
| __ Move(rcx, constant_properties);
|
| __ Move(rdx, Smi::FromInt(flags));
|
| - FastCloneShallowObjectStub stub(isolate(), properties_count);
|
| + FastCloneShallowObjectStub stub(isolate(), expr->properties_count());
|
| __ CallStub(&stub);
|
| }
|
| PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG);
|
| @@ -1858,20 +1850,9 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {
|
| Comment cmnt(masm_, "[ ArrayLiteral");
|
|
|
| expr->BuildConstantElements(isolate());
|
| - int flags = expr->depth() == 1
|
| - ? ArrayLiteral::kShallowElements
|
| - : ArrayLiteral::kNoFlags;
|
| -
|
| - ZoneList<Expression*>* subexprs = expr->values();
|
| - int length = subexprs->length();
|
| Handle<FixedArray> constant_elements = expr->constant_elements();
|
| - DCHECK_EQ(2, constant_elements->length());
|
| - ElementsKind constant_elements_kind =
|
| - static_cast<ElementsKind>(Smi::cast(constant_elements->get(0))->value());
|
| bool has_constant_fast_elements =
|
| - IsFastObjectElementsKind(constant_elements_kind);
|
| - Handle<FixedArrayBase> constant_elements_values(
|
| - FixedArrayBase::cast(constant_elements->get(1)));
|
| + IsFastObjectElementsKind(expr->constant_elements_kind());
|
|
|
| AllocationSiteMode allocation_site_mode = TRACK_ALLOCATION_SITE;
|
| if (has_constant_fast_elements && !FLAG_allocation_site_pretenuring) {
|
| @@ -1880,12 +1861,12 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {
|
| allocation_site_mode = DONT_TRACK_ALLOCATION_SITE;
|
| }
|
|
|
| - if (expr->depth() > 1 || length > JSObject::kInitialMaxFastElementArray) {
|
| + if (MustCreateArrayLiteralWithRuntime(expr)) {
|
| __ movp(rbx, Operand(rbp, JavaScriptFrameConstants::kFunctionOffset));
|
| __ Push(FieldOperand(rbx, JSFunction::kLiteralsOffset));
|
| __ Push(Smi::FromInt(expr->literal_index()));
|
| __ Push(constant_elements);
|
| - __ Push(Smi::FromInt(flags));
|
| + __ Push(Smi::FromInt(expr->ComputeFlags()));
|
| __ CallRuntime(Runtime::kCreateArrayLiteral, 4);
|
| } else {
|
| __ movp(rbx, Operand(rbp, JavaScriptFrameConstants::kFunctionOffset));
|
| @@ -1898,6 +1879,8 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {
|
| PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG);
|
|
|
| bool result_saved = false; // Is the result saved to the stack?
|
| + ZoneList<Expression*>* subexprs = expr->values();
|
| + int length = subexprs->length();
|
|
|
| // Emit code to evaluate all the non-constant subexpressions and to store
|
| // them into the newly cloned array.
|
| @@ -1914,7 +1897,7 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {
|
| }
|
| VisitForAccumulatorValue(subexpr);
|
|
|
| - if (IsFastObjectElementsKind(constant_elements_kind)) {
|
| + if (has_constant_fast_elements) {
|
| // Fast-case array literal with ElementsKind of FAST_*_ELEMENTS, they
|
| // cannot transition and don't need to call the runtime stub.
|
| int offset = FixedArray::kHeaderSize + (i * kPointerSize);
|
|
|