Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: BUILD.gn

Issue 1037193003: [GN] Use correct toolchain for x64 target on Android (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 0af482b2c9ea711566acda9b9c941836f82d7cca..ded76e06c069cccfc7762e777352f46ed215bebd 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -1397,6 +1397,7 @@ source_set("v8_libbase") {
libs = [ "dl", "rt" ]
} else if (is_android) {
defines += [ "CAN_USE_VFP_INSTRUCTIONS" ]
+ libs = [ "dl", "log" ]
jochen (gone - plz use gerrit) 2015/03/27 11:59:56 log is only needed for the target toolchain, no?
haltonhuo 2015/03/30 02:15:09 Adding rt will cause -lrt not found error. Actuall
haltonhuo 2015/03/30 07:35:15 Uploaded patch set2 is more correct way to go. Ple
if (host_os == "mac") {
if (current_toolchain == host_toolchain) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698