Work around a bug in the NCryptSignHash implementation of some smartcards.

Work around a bug in the NCryptSignHash implementation of some smartcards.

Some smartcards do not properly handle the output length (either bounds
checking or returning the output size) when the output buffer is non-NULL.
Work around those by calling twice despite already having a pre-allocated
buffer.

BUG=470204
Committed: https://crrev.com/52850c1e665f3f18e3e6d6b9c46c7763e858c041
Cr-Commit-Position: refs/heads/master@{#322632}

[davidben, 2015-03-26 23:43:37]

davidben@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2015-03-27 07:00:39]

lgtm

https://codereview.chromium.org/1037123002/diff/40001/net/ssl/openssl_platfor...
File net/ssl/openssl_platform_key_win.cc (right):

https://codereview.chromium.org/1037123002/diff/40001/net/ssl/openssl_platfor...
net/ssl/openssl_platform_key_win.cc:180: size_t* out_len,
Why is this a size_t? Why not consistent type and just use DWORD?

https://codereview.chromium.org/1037123002/diff/40001/net/ssl/openssl_platfor...
net/ssl/openssl_platform_key_win.cc:268: size_t out_len_size_t;
Reverse Hungarian Notation? :D

why not signature_len?

whatever it is, suffix size_t = embiggening my emsaddening.

[davidben, 2015-03-27 18:59:23]

https://codereview.chromium.org/1037123002/diff/40001/net/ssl/openssl_platfor...
File net/ssl/openssl_platform_key_win.cc (right):

https://codereview.chromium.org/1037123002/diff/40001/net/ssl/openssl_platfor...
net/ssl/openssl_platform_key_win.cc:180: size_t* out_len,
On 2015/03/27 07:00:38, Ryan Sleevi wrote:
> Why is this a size_t? Why not consistent type and just use DWORD?

I figured I'd push the native types -> Windows boundary down a level. Switched
these all to Windows types at this level.

https://codereview.chromium.org/1037123002/diff/40001/net/ssl/openssl_platfor...
net/ssl/openssl_platform_key_win.cc:268: size_t out_len_size_t;
On 2015/03/27 07:00:37, Ryan Sleevi wrote:
> Reverse Hungarian Notation? :D
> 
> why not signature_len?
> 
> whatever it is, suffix size_t = embiggening my emsaddening.

Done.

[davidben, 2015-03-27 18:59:41]

The CQ bit was checked by davidben@chromium.org

[davidben, 2015-03-27 18:59:41]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1037123002/#ps80001
(title: "unnecessary churn")

[commit-bot: I haz the power, 2015-03-27 19:00:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1037123002/80001

[commit-bot: I haz the power, 2015-03-27 20:24:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-27 20:26:11]

Patchset 5 (id:??) landed as
https://crrev.com/52850c1e665f3f18e3e6d6b9c46c7763e858c041
Cr-Commit-Position: refs/heads/master@{#322632}