Fix a crash seen in Desktop Chrome Windows while displaying a bubble

ui/base/ime/input_method_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/ime/input_method_win.h"
 
 #include "base/basictypes.h"
 #include "base/profiler/scoped_tracker.h"
 #include "ui/base/ime/text_input_client.h"
 #include "ui/base/ime/win/tsf_input_scope.h"
@@ skipping 14 matching lines @@
 }  // namespace
 
 InputMethodWin::InputMethodWin(internal::InputMethodDelegate* delegate,
                                HWND toplevel_window_handle)
     : toplevel_window_handle_(toplevel_window_handle),
       pending_requested_direction_(base::i18n::UNKNOWN_DIRECTION),
       accept_carriage_return_(false),
       active_(false),
       enabled_(false),
       is_candidate_popup_open_(false),
-      composing_window_handle_(NULL) {
+      composing_window_handle_(NULL),
+      default_input_language_initialized_(false) {
   SetDelegate(delegate);
   // In non-Aura environment, appropriate callbacks to OnFocus() and OnBlur()
   // are not implemented yet. To work around this limitation, here we use
   // "always focused" model.
   // TODO(ime): Fix the caller of OnFocus() and OnBlur() so that appropriate
   // focus event will be passed.
   InputMethodBase::OnFocus();
 }
 
 void InputMethodWin::Init(bool focused) {
-  // Gets the initial input locale.
-  OnInputLocaleChanged();
-
   InputMethodBase::Init(focused);
 }
 
 void InputMethodWin::OnFocus() {
   // Ignore OnFocus event for "always focused" model. See the comment in the
   // constructor.
   // TODO(ime): Implement OnFocus once the callers are fixed.
 }
 
 void InputMethodWin::OnBlur() {
   // Ignore OnBlur event for "always focused" model. See the comment in the
   // constructor.
   // TODO(ime): Implement OnFocus once the callers are fixed.
 }
 
 bool InputMethodWin::OnUntranslatedIMEMessage(
     const base::NativeEvent& event,
     InputMethod::NativeEventResult* result) {
   LRESULT original_result = 0;
   BOOL handled = FALSE;
+
+  if (!default_input_language_initialized_) {
+    default_input_language_initialized_ = true;

[msw, 2015/03/27 19:05:23]

Nix this, it's set in OnInputLocaleChanged().

[ananta, 2015/03/27 19:08:38]

Done.

+      // Gets the initial input locale.

[msw, 2015/03/27 19:05:23]

Optionally nix comment and curlies, or outdent this by two spaces.

[ananta, 2015/03/27 19:08:38]

Done.

+    OnInputLocaleChanged();
+  }
+
   switch (event.message) {
     case WM_IME_SETCONTEXT:
       original_result = OnImeSetContext(
           event.hwnd, event.message, event.wParam, event.lParam, &handled);
       break;
     case WM_IME_STARTCOMPOSITION:
       original_result = OnImeStartComposition(
           event.hwnd, event.message, event.wParam, event.lParam, &handled);
       break;
     case WM_IME_COMPOSITION:
@@ skipping 93 matching lines @@
                        screen_bounds.size());
   imm32_manager_.UpdateCaretRect(attached_window, caret_rect);
 }
 
 void InputMethodWin::CancelComposition(const TextInputClient* client) {
   if (enabled_ && IsTextInputClientFocused(client))
     imm32_manager_.CancelIME(GetAttachedWindowHandle(client));
 }
 
 void InputMethodWin::OnInputLocaleChanged() {
+  default_input_language_initialized_ = true;
   active_ = imm32_manager_.SetInputLanguage();
   locale_ = imm32_manager_.GetInputLanguageName();
   OnInputMethodChanged();
 }
 
 std::string InputMethodWin::GetInputLocale() {
   return locale_;
 }
 
 bool InputMethodWin::IsActive() {
@@ skipping 449 matching lines @@
       enabled_ = true;
       break;
   }
 
   imm32_manager_.SetTextInputMode(window_handle, text_input_mode);
   tsf_inputscope::SetInputScopeForTsfUnawareWindow(
       window_handle, text_input_type, text_input_mode);
 }
 
 }  // namespace ui