Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1037053003: Update extension permission histogram (Closed)

Created:
5 years, 9 months ago by tbarzic
Modified:
5 years, 9 months ago
Reviewers:
Yoyo Zhou, Ilya Sherman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update extension permission histogram This adds histogram values for extension permission messages that are missing. BUG=None TEST=None Committed: https://crrev.com/1c45aec35f3cbb85ed20273d204c2126cf1de275 Cr-Commit-Position: refs/heads/master@{#322474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M extensions/common/permissions/permission_message.h View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tbarzic
5 years, 9 months ago (2015-03-26 18:29:20 UTC) #2
Yoyo Zhou
LGTM, thanks for doing this.
5 years, 9 months ago (2015-03-26 19:47:35 UTC) #3
Ilya Sherman
LGTM. Thanks, Toni :)
5 years, 9 months ago (2015-03-26 20:26:35 UTC) #4
tbarzic
On 2015/03/26 20:26:35, Ilya Sherman wrote: > LGTM. Thanks, Toni :) np :)
5 years, 9 months ago (2015-03-26 20:27:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037053003/1
5 years, 9 months ago (2015-03-26 20:27:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 21:26:01 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 21:27:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c45aec35f3cbb85ed20273d204c2126cf1de275
Cr-Commit-Position: refs/heads/master@{#322474}

Powered by Google App Engine
This is Rietveld 408576698