Issue 1037043002: Test for net::ERR_ICANN_NAME_COLLISION in other places that check host resolover failures.

Issue 1037043002: Test for net::ERR_ICANN_NAME_COLLISION in other places that check host resolover failures. (Closed)

Created:
5 years, 9 months ago by eroman

Modified:
5 years, 8 months ago

Reviewers:
dmichael (off chromium), sgurun-gerrit only, mmenke

CC:
chromium-reviews, android-webview-reviews_chromium.org, Ryan Sleevi

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Test for net::ERR_ICANN_NAME_COLLISION in other places that check host resolover failures. BUG=470704 Committed: https://crrev.com/9004cf38091c4e82f47e5cdeeb1f71e676e28855 Cr-Commit-Position: refs/heads/master@{#322619}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	android_webview/java/src/org/chromium/android_webview/ErrorCodeConversionHelper.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	ppapi/host/error_conversion.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 13 (3 generated)

eroman

I split this off from the error page CL, so it is less stuff to ...

5 years, 9 months ago (2015-03-26 15:06:33 UTC) #2

mmenke

On 2015/03/26 15:06:33, eroman wrote: > I split this off from the error page CL, ...

5 years, 9 months ago (2015-03-26 15:11:30 UTC) #3

mmenke

On 2015/03/26 15:15:48, eroman wrote: > Not familiar with that; will take a look, thanks! ...

5 years, 9 months ago (2015-03-26 15:19:19 UTC) #5

eroman

+sgurun for android_webview OWNER +dmichael for ppapi OWNER

5 years, 9 months ago (2015-03-26 15:21:37 UTC) #7

sgurun-gerrit only

On 2015/03/26 17:25:50, dmichael wrote: > ppapi lgtm aw lgtm

5 years, 9 months ago (2015-03-27 16:00:57 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037043002/20001

5 years, 8 months ago (2015-03-27 17:21:54 UTC) #11

commit-bot: I haz the power

5 years, 8 months ago (2015-03-27 19:05:48 UTC) #13

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/9004cf38091c4e82f47e5cdeeb1f71e676e28855
Cr-Commit-Position: refs/heads/master@{#322619}