Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gin/wrappable.h

Issue 103703002: Gin: Add support for binding JS methods to C++ instance methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blah Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gin/try_catch.cc ('K') | « gin/try_catch.cc ('k') | gin/wrappable.cc » ('j') | gin/wrappable.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/wrappable.h
diff --git a/gin/wrappable.h b/gin/wrappable.h
index bad7958adab4cae788e9b257545e99e0ade4f812..6922d679b650a6cd57e44c4360023d376e2bffcc 100644
--- a/gin/wrappable.h
+++ b/gin/wrappable.h
@@ -82,7 +82,7 @@ struct WrappableConverter {
return Converter<Wrappable*>::ToV8(isolate, val);
}
static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val, T** out) {
- Wrappable* wrappable = 0;
Aaron Boodman 2013/12/04 07:05:29 We use NULL, not zero in Chrome code
abarth-chromium 2013/12/04 16:27:55 Yep!
+ Wrappable* wrappable = NULL;
if (!Converter<Wrappable*>::FromV8(isolate, val, &wrappable)
|| wrappable->GetWrapperInfo() != &T::kWrapperInfo)
return false;
« gin/try_catch.cc ('K') | « gin/try_catch.cc ('k') | gin/wrappable.cc » ('j') | gin/wrappable.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698