Gin: Add support for binding JS methods to C++ instance methods.

gin/wrappable.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gin/wrappable.h"
 
 #include "base/logging.h"
 #include "gin/per_isolate_data.h"
 
 namespace gin {
@@ skipping 16 matching lines @@
   Wrappable* wrappable = data.GetParameter();
   wrappable->wrapper_.Reset();
   wrappable->Release();  // Balanced in Wrappable::ConfigureWrapper.
 }
 
 v8::Handle<v8::Object> Wrappable::CreateWrapper(v8::Isolate* isolate) {
   WrapperInfo* info = GetWrapperInfo();
   PerIsolateData* data = PerIsolateData::From(isolate);
   v8::Local<v8::ObjectTemplate> templ = data->GetObjectTemplate(info);
   CHECK(!templ.IsEmpty());  // Don't forget to register an object template.
-  CHECK(templ->InternalFieldCount() == kNumberOfInternalFields);
+  CHECK_EQ(kNumberOfInternalFields, templ->InternalFieldCount());

[Aaron Boodman, 2013/12/04 07:05:29]

So that the mismatch is printed in the logs if this checks.

[abarth-chromium, 2013/12/04 16:27:55]

Thanks for fixing these.  My Chromium idioms are a bit rusty.

   v8::Handle<v8::Object> wrapper = templ->NewInstance();
   wrapper->SetAlignedPointerInInternalField(kWrapperInfoIndex, info);
   wrapper->SetAlignedPointerInInternalField(kEncodedValueIndex, this);
   wrapper_.Reset(isolate, wrapper);
   AddRef();  // Balanced in Wrappable::WeakCallback.
   wrapper_.SetWeak(this, WeakCallback);
   return wrapper;
 }
 
 v8::Handle<v8::Value> Converter<Wrappable*>::ToV8(v8::Isolate* isolate,
@@ skipping 12 matching lines @@
   if (!info)
     return false;
   void* pointer = obj->GetAlignedPointerFromInternalField(kEncodedValueIndex);
   Wrappable* wrappable = static_cast<Wrappable*>(pointer);
   CHECK(wrappable->GetWrapperInfo() == info);  // Security check for cast above.
   *out = wrappable;
   return true;
 }
 
 }  // namespace gin