Gin: Add support for binding JS methods to C++ instance methods.

gin/try_catch.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gin/try_catch.h"
 
 #include <sstream>
 
-#include "base/logging.h"
 #include "gin/converter.h"
 
 namespace gin {
 
 TryCatch::TryCatch() {
 }
 
 TryCatch::~TryCatch() {
 }
 
 bool TryCatch::HasCaught() {
   return try_catch_.HasCaught();
 }
 
 std::string TryCatch::GetStackTrace() {
+  if (!HasCaught()) {
+    return "";
+  }
+
   std::stringstream ss;
   v8::Handle<v8::Message> message = try_catch_.Message();

[Aaron Boodman, 2013/12/04 07:05:29]

FYI, this technically doesn't adhere to the styleguide:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Stream...

But it's pretty convenient to write this way, so ima let it slide.

[abarth-chromium, 2013/12/04 16:27:55]

Oh!  Sorry.  :)

   ss << V8ToString(message->Get()) << std::endl
      << V8ToString(message->GetSourceLine()) << std::endl;
 
   v8::Handle<v8::StackTrace> trace = message->GetStackTrace();
   if (trace.IsEmpty())
     return ss.str();
 
   int len = trace->GetFrameCount();
   for (int i = 0; i < len; ++i) {
     v8::Handle<v8::StackFrame> frame = trace->GetFrame(i);
     ss << V8ToString(frame->GetScriptName()) << ":"
        << frame->GetLineNumber() << ":"
        << frame->GetColumn() << ": "
        << V8ToString(frame->GetFunctionName())
        << std::endl;
   }
   return ss.str();
 }
 
 }  // namespace gin