base/third_party/xdg_mime/README.chromium - Issue 1037023002: Do not free pointer when you are going to use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/third_party/xdg_mime/README.chromium

Issue 1037023002: Do not free pointer when you are going to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code according to suggestions Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/third_party/xdg_mime/README.chromium

diff --git a/base/third_party/xdg_mime/README.chromium b/base/third_party/xdg_mime/README.chromium

index 29d239a4ce0d10927b10ffd8e6443129100c7d45..ce9e8922e77d1974416e133adc74534a9c0a07a8 100644

--- a/base/third_party/xdg_mime/README.chromium

+++ b/base/third_party/xdg_mime/README.chromium

@@ -7,5 +7,6 @@ git://anongit.freedesktop.org/xdg/xdgmime

@ 2cdd8d36d7930d5a594587286cb1949ff62f7027 on 2012/08/06.

In addition, we have the following patch(es):

-- compile.patch: small tweaks to make the code compile.

-- Added a LICENSE file.

+ - compile.patch: small tweaks to make the code compile.

gburanov 2015/04/20 09:50:07 Added spaces exactly as in base/third_party/dmg_fp

+ - free_pointer_later.patch: small patch that fixes potential crash - use pointer after being freed.

Lei Zhang 2015/04/20 19:14:02 Would you mind not going over 80 chars / line?

gburanov 2015/04/22 14:21:55 done!

+ - Added a LICENSE file.