Do not free pointer when you are going to use it

base/third_party/xdg_mime/xdgmime.c

 /* -*- mode: C; c-file-style: "gnu" -*- */
 /* xdgmime.c: XDG Mime Spec mime resolver.  Based on version 0.11 of the spec.
  *
  * More info can be found at http://www.freedesktop.org/standards/
  * 
  * Copyright (C) 2003,2004  Red Hat, Inc.
  * Copyright (C) 2003,2004  Jonathan Blandford <jrb@alum.mit.edu>
  *
  * Licensed under the Academic Free License version 2.0
  * Or under the following terms:
@@ skipping 540 matching lines @@
   if (ferror (file))
     {
       free (data);
       fclose (file);
       return XDG_MIME_TYPE_UNKNOWN;
     }
 
   mime_type = _xdg_mime_magic_lookup_data (global_magic, data, bytes_read, NULL,
                                            mime_types, n);
 
-  free (data);
   fclose (file);
 
-  if (mime_type)
+  if (mime_type) {

[Lei Zhang, 2015/04/16 18:31:35]

So how about:

if (!mime_type)
  mime_type = _xdg_binary_or_text_fallback(data, bytes_read);

free (data);
return mime_type;

+    free (data);
     return mime_type;
+  }
 
-  return _xdg_binary_or_text_fallback(data, bytes_read);
+  mime_type = _xdg_binary_or_text_fallback(data, bytes_read);
+  free (data);
+  return mime_type;
 }
 
 const char *
 xdg_mime_get_mime_type_from_file_name (const char *file_name)
 {
   const char *mime_type;
 
   xdg_mime_init ();
 
   if (_caches)
@@ skipping 347 matching lines @@
 const char *
 xdg_mime_get_generic_icon (const char *mime)
 {
   xdg_mime_init ();
   
   if (_caches)
     return _xdg_mime_cache_get_generic_icon (mime);
 
   return _xdg_mime_icon_list_lookup (generic_icon_list, mime);
 }