Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 1037013002: Reland: Debugger: deduplicate shared function info when setting script break points. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of Debugger: deduplicate shared function info when setting script break points. (patchset #1 id:1 of https://codereview.chromium.org/999273003/) Reason for revert: Reland since the failure has been fixed in https://codereview.chromium.org/1035523005/ Original issue's description: > Revert of Debugger: deduplicate shared function info when setting script break points. (patchset #4 id:60001 of https://codereview.chromium.org/998253005/) > > Reason for revert: > Code caching failures. > > Original issue's description: > > Debugger: deduplicate shared function info when setting script break points. > > > > Also fix Debug.showBreakPoints for multiple break points at the same location. > > > > BUG=v8:3960 > > LOG=N > > > > Committed: https://crrev.com/73b17a71a22564c0b66d9aa7c00948c748f5b290 > > Cr-Commit-Position: refs/heads/master@{#27444} > > TBR=mstarzinger@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3960 > > Committed: https://crrev.com/9b29d008dfcc00bf56be8040add1d2c5e404673b > Cr-Commit-Position: refs/heads/master@{#27448} TBR=mstarzinger@chromium.org BUG=v8:3960 LOG=N Committed: https://crrev.com/69383d6366891c8b1eb2240af55b3ef40628efa6 Cr-Commit-Position: refs/heads/master@{#27472}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -18 lines) Patch
M src/compiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 1 3 chunks +27 lines, -14 lines 0 comments Download
M src/liveedit.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M test/mjsunit/debug-liveedit-2.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-liveedit-4.js View 1 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-3960.js View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yang
Created Revert of Revert of Debugger: deduplicate shared function info when setting script break points.
5 years, 9 months ago (2015-03-26 09:57:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037013002/1
5 years, 9 months ago (2015-03-26 09:58:17 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4248)
5 years, 9 months ago (2015-03-26 09:59:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037013002/210001
5 years, 9 months ago (2015-03-26 10:21:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:210001)
5 years, 9 months ago (2015-03-26 10:43:41 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 10:44:00 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69383d6366891c8b1eb2240af55b3ef40628efa6
Cr-Commit-Position: refs/heads/master@{#27472}

Powered by Google App Engine
This is Rietveld 408576698