Retry r41799:...

Retry r41799:

Basic DragImage implementation.

Only the chromium part is for review. The webkit part shows how that will look when I create the patch for webkit later. This can be landed without the change to webkit.

TODO later:
- use the image on windows, mac
- implement the other DragImageRef functions

TEST=drag an image from the render view in GTK
BUG=11457
Review URL: http://codereview.chromium.org/668125

The problem was an incorrect method signature in RenderView.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41953

[Evan Stade, 2010-03-17 21:22:35]

I was wrong; it did affect linux, it just didn't affect *me* because of some
local code modifications.

[Evan Stade, 2010-03-17 21:35:35]

trybots with correct base revision:
http://build.chromium.org/buildbot/try-server/builders/win/builds/23529
http://build.chromium.org/buildbot/try-server/builders/mac/builds/22505
http://build.chromium.org/buildbot/try-server/builders/linux/builds/22483

[jam, 2010-03-17 21:57:27]

I'm not familiar with this code, can it be sent for review to the original
reviewer?

On Wed, Mar 17, 2010 at 2:35 PM, <estade@chromium.org> wrote:

> trybots with correct base revision:
> http://build.chromium.org/buildbot/try-server/builders/win/builds/23529
> http://build.chromium.org/buildbot/try-server/builders/mac/builds/22505
> http://build.chromium.org/buildbot/try-server/builders/linux/builds/22483
>
>
> http://codereview.chromium.org/1037008
>

[Evan Stade, 2010-03-17 22:08:03]

+tony

http://codereview.chromium.org/1037008/diff/1/25
File chrome/renderer/render_view.h (right):

http://codereview.chromium.org/1037008/diff/1/25#newcode252
chrome/renderer/render_view.h:252: virtual void startDragging(
this was the method signature I messed up last time.

[tony, 2010-03-18 00:10:14]

LG