Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 1037003002: Only use web app frame for bookmark apps. (Closed)

Created:
5 years, 9 months ago by benwells
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only use web app frame for bookmark apps. The web app frame is experimental and should only be used by bookmark apps. This change also moves tests for bookmark app browser functionality out of the general browser browser tests file into a separate file. BUG=368372 Committed: https://crrev.com/75bd9665feeb61f650bce70a52f8773c2a800cd7 Cr-Commit-Position: refs/heads/master@{#322435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -212 lines) Patch
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 3 chunks +0 lines, -210 lines 0 comments Download
A chrome/browser/ui/extensions/bookmark_app_browsertest.cc View 1 chunk +246 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/web_app_left_header_view_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
Note I'll be moving all the bookmark app stuff out of browser.cc in a follow ...
5 years, 9 months ago (2015-03-26 07:47:52 UTC) #2
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-26 18:27:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037003002/1
5 years, 9 months ago (2015-03-26 18:28:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 18:32:57 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 18:33:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75bd9665feeb61f650bce70a52f8773c2a800cd7
Cr-Commit-Position: refs/heads/master@{#322435}

Powered by Google App Engine
This is Rietveld 408576698