Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1036943004: Use custom scrollbars for print preview on non-retina mac displays. (Closed)

Created:
5 years, 9 months ago by raymes
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang, Sam McNally
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use custom scrollbars for print preview on non-retina mac displays. This is a hack to workaround a blink bug where overlay scrollbars aren't rendered correctly in print preview. This bug is being looked at but until then we use custom scrollbars that imitate mac scrollbars only in this specific case. BUG=466039 Committed: https://crrev.com/6826023abd24c8aa8981f4f0fadcf98f0f962bba Cr-Commit-Position: refs/heads/master@{#322331}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/main.js View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_scripting_api.js View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
A chrome/browser/resources/pdf/scrollbars_mac.css View 1 2 3 4 5 6 7 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
raymes
5 years, 9 months ago (2015-03-26 02:10:58 UTC) #2
Lei Zhang
My CSS-fu is weak, so I defer to Sam if he's comfortable reviewing this.
5 years, 9 months ago (2015-03-26 02:12:19 UTC) #3
Sam McNally
LGTM https://codereview.chromium.org/1036943004/diff/40001/chrome/browser/resources/component_extension_resources.grd File chrome/browser/resources/component_extension_resources.grd (right): https://codereview.chromium.org/1036943004/diff/40001/chrome/browser/resources/component_extension_resources.grd#newcode182 chrome/browser/resources/component_extension_resources.grd:182: <include name="IDR_PDF_SCROLLBARS_CSS" file="pdf/scrollbars-mac.css" allowexternalscript="true" type="BINDATA" /> scrollbars_mac.css Remove ...
5 years, 9 months ago (2015-03-26 02:31:54 UTC) #4
Lei Zhang
.grd file lgtm
5 years, 9 months ago (2015-03-26 02:33:18 UTC) #5
raymes
https://codereview.chromium.org/1036943004/diff/40001/chrome/browser/resources/component_extension_resources.grd File chrome/browser/resources/component_extension_resources.grd (right): https://codereview.chromium.org/1036943004/diff/40001/chrome/browser/resources/component_extension_resources.grd#newcode182 chrome/browser/resources/component_extension_resources.grd:182: <include name="IDR_PDF_SCROLLBARS_CSS" file="pdf/scrollbars-mac.css" allowexternalscript="true" type="BINDATA" /> On 2015/03/26 02:31:54, ...
5 years, 9 months ago (2015-03-26 04:30:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036943004/120001
5 years, 9 months ago (2015-03-26 04:30:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/52004)
5 years, 9 months ago (2015-03-26 04:38:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036943004/140001
5 years, 9 months ago (2015-03-26 05:14:29 UTC) #14
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 9 months ago (2015-03-26 05:57:09 UTC) #15
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/6826023abd24c8aa8981f4f0fadcf98f0f962bba Cr-Commit-Position: refs/heads/master@{#322331}
5 years, 9 months ago (2015-03-26 05:57:48 UTC) #16
raymes
5 years, 8 months ago (2015-04-13 01:48:38 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1085483002/ by raymes@chromium.org.

The reason for reverting is: The bug this hack is working around was fixed in  
http://src.chromium.org/viewvc/blink?view=rev&rev=193593. This hack can now be
reverted..

Powered by Google App Engine
This is Rietveld 408576698