Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1036933002: StocksApp hits an ASSERT when bringing up search (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
ojan
CC:
ojan, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

StocksApp hits an ASSERT when bringing up search Previously we'd hit an ASSERT that elements in the style sharing list support style sharing. However, it can happen that an element gets added to the style sharing list and then loses the ability to share styles because it has an active animation. This CL works around the problem by skiping over those elements when considering style sharing candidates. A better solution would be to clear the style sharing list when it might contain such an element. However, it's likely we will remove style sharing in the future so its easier to just work aroudn the issue for now. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/87bb01abb44df3a6dd05688fc076814f1d233f05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M sky/engine/core/css/resolver/SharedStyleFinder.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-25 22:29:51 UTC) #1
ojan
lgtm
5 years, 9 months ago (2015-03-25 22:31:02 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-25 23:08:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
87bb01abb44df3a6dd05688fc076814f1d233f05 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698