Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2296)

Issue 1036913002: Pepper: CallOnMainThread should do nothing if Globals are gone (Closed)

Created:
5 years, 9 months ago by dmichael (off chromium)
Modified:
5 years, 9 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pepper: CallOnMainThread should do nothing if Globals are gone BUG=339912 Committed: https://crrev.com/18a876a21927546da4868a3afaf78aa6fdd77caa Cr-Commit-Position: refs/heads/master@{#322259}

Patch Set 1 #

Total comments: 2

Patch Set 2 : improve comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ppapi/proxy/ppb_core_proxy.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dmichael (off chromium)
5 years, 9 months ago (2015-03-25 20:31:26 UTC) #2
bbudge
lgtm https://codereview.chromium.org/1036913002/diff/1/ppapi/proxy/ppb_core_proxy.cc File ppapi/proxy/ppb_core_proxy.cc (right): https://codereview.chromium.org/1036913002/diff/1/ppapi/proxy/ppb_core_proxy.cc#newcode68 ppapi/proxy/ppb_core_proxy.cc:68: // at shutdown, it's possible that the globals ...
5 years, 9 months ago (2015-03-25 20:54:45 UTC) #3
dmichael (off chromium)
thanks! https://codereview.chromium.org/1036913002/diff/1/ppapi/proxy/ppb_core_proxy.cc File ppapi/proxy/ppb_core_proxy.cc (right): https://codereview.chromium.org/1036913002/diff/1/ppapi/proxy/ppb_core_proxy.cc#newcode68 ppapi/proxy/ppb_core_proxy.cc:68: // at shutdown, it's possible that the globals ...
5 years, 9 months ago (2015-03-25 21:33:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036913002/20001
5 years, 9 months ago (2015-03-25 21:34:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-25 23:28:33 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 23:29:20 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/18a876a21927546da4868a3afaf78aa6fdd77caa
Cr-Commit-Position: refs/heads/master@{#322259}

Powered by Google App Engine
This is Rietveld 408576698