Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1036893002: Make GC test catch strong ref from client objects (Closed)

Created:
5 years, 9 months ago by boliu
Modified:
5 years, 6 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, jdduke (slow), Tobias Sargeant
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make GC test catch strong ref from client objects In the public sdk API, apps should be able to hold a strong WebView reference from WebChromeClient or WebViewClient, without having to worry about preventing WebView from gc-ed. Simulate that behavior in testCreateAndGcManyTimes by having the AwContentsClient hold a strong reference to AwContents. And remove the strong ref from AwWebContentsObserver to make the test pass. BUG=469803 Committed: https://crrev.com/9a424d2eeb702d73fb6173e3e70827d77d68ddb7 Cr-Commit-Position: refs/heads/master@{#322380}

Patch Set 1 #

Patch Set 2 : Fix test and AwWebContentsObserver #

Patch Set 3 : visual state callback can't hold strong ref either #

Patch Set 4 : findbugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java View 1 2 3 chunks +19 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 1 2 3 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
boliu
torne for review We might want to do an audit of all our callback interfaces. ...
5 years, 9 months ago (2015-03-25 19:05:11 UTC) #2
Torne
lgtm
5 years, 9 months ago (2015-03-26 10:31:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036893002/40001
5 years, 9 months ago (2015-03-26 13:53:32 UTC) #5
boliu
Had to suppress an "Unread field" findbugs error in the StrongRefTestAwContentsClient class.
5 years, 9 months ago (2015-03-26 14:22:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036893002/60001
5 years, 9 months ago (2015-03-26 14:23:01 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-26 14:53:03 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 14:53:59 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9a424d2eeb702d73fb6173e3e70827d77d68ddb7
Cr-Commit-Position: refs/heads/master@{#322380}

Powered by Google App Engine
This is Rietveld 408576698