Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1036883002: Simplify IPC::SyncMessageSchema::WriteReplyParams() using variadic templates (Closed)

Created:
5 years, 9 months ago by Mikhail
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify IPC::SyncMessageSchema::WriteReplyParams() using variadic templates Committed: https://crrev.com/cd0a664ae0737c990ba281c1f9b2afb23b3c65d3 Cr-Commit-Position: refs/heads/master@{#322368}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Applied the comments from Tom #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -27 lines) Patch
M ipc/ipc_message_utils.h View 1 1 chunk +3 lines, -27 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Mikhail
PTAL
5 years, 9 months ago (2015-03-25 15:30:53 UTC) #2
Tom Sepez
Excellent. LGTM after fixing a few nits, which are really minor. https://codereview.chromium.org/1036883002/diff/1/ipc/ipc_message_utils.h File ipc/ipc_message_utils.h (right): ...
5 years, 9 months ago (2015-03-25 17:11:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036883002/20001
5 years, 9 months ago (2015-03-26 09:33:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/47656)
5 years, 9 months ago (2015-03-26 11:00:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036883002/20001
5 years, 9 months ago (2015-03-26 11:16:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 12:24:46 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 12:25:12 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd0a664ae0737c990ba281c1f9b2afb23b3c65d3
Cr-Commit-Position: refs/heads/master@{#322368}

Powered by Google App Engine
This is Rietveld 408576698