Fix to respect --explicitly-allowed-ports command line option-Chromium Side

content/child/blink_platform_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/blink_platform_impl.h"
 
 #include "base/run_loop.h"
 #include "base/time/time.h"
 #include "net/base/net_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebString.h"
+

[eroman, 2015/04/13 15:55:35]

Remove this blank line

 #include "third_party/WebKit/public/web/WebSecurityOrigin.h"
 
 namespace content {
 
 // Derives BlinkPlatformImpl for testing shared timers.
 class TestBlinkPlatformImpl : public BlinkPlatformImpl {
  public:
   TestBlinkPlatformImpl() : mock_monotonically_increasing_time_(0) {}
 
   // Returns mock time when enabled.
@@ skipping 91 matching lines @@
     if (i == 0 || i == 10 || i == 127 || i > 223) {
       EXPECT_TRUE(platform_impl.isReservedIPAddress(
           blink::WebString::fromUTF8(addressString)));
     } else {
       EXPECT_FALSE(platform_impl.isReservedIPAddress(
           blink::WebString::fromUTF8(addressString)));
     }
   }
 }
 
+TEST(BlinkPlatformTest, portAllowed) {
+ TestBlinkPlatformImpl platform_impl;

[tyoshino (SeeGerritForStatus), 2015/04/13 14:28:16]

two space indent

+ EXPECT_TRUE(platform_impl.portAllowed(GURL("example.com")));
+ EXPECT_TRUE(platform_impl.portAllowed(GURL("file://example.com")));

[eroman, 2015/04/13 15:55:35]

please also add a test for file:// containing "ports"

+ EXPECT_TRUE(platform_impl.portAllowed(GURL("ftp://example.com:21")));
+ EXPECT_FALSE(platform_impl.portAllowed(GURL("ftp://example.com:87")));
+ EXPECT_FALSE(platform_impl.portAllowed(GURL("ws://example.com:21")));
+ EXPECT_TRUE(platform_impl.portAllowed(GURL("http://example.com:80")));

[eroman, 2015/04/13 15:55:35]

please include tests which contain no explicitly specified port.

+}
+
 }  // namespace content