Fix to respect --explicitly-allowed-ports command line option-Chromium Side

content/child/blink_platform_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/blink_platform_impl.h"
 
 #include <math.h>
 
 #include <vector>
 
@@ skipping 487 matching lines @@
 }
 
 bool BlinkPlatformImpl::isReservedIPAddress(
     const blink::WebString& host) const {
   net::IPAddressNumber address;
   if (!net::ParseURLHostnameToNumber(host.utf8(), &address))
     return false;
   return net::IsIPAddressReserved(address);
 }
 
+bool BlinkPlatformImpl::portAllowed(const blink::WebURL& url) const {
+  GURL gurl = GURL(url);
+  int port = gurl.IntPort();
+  if (gurl.SchemeIsFile())

[eroman, 2015/04/13 15:55:34]

I think in the case of a file:// URL gurl.has_port() will be false. Please
confirm this. If it is the case, then the test for gurl.has_port() below is
sufficient and no special case for file:// is needed.

[Paritosh Kumar, 2015/04/14 14:50:35]

Thanks. Done.

+    return true;
+  if (gurl.has_port()) {

[eroman, 2015/04/13 15:55:35]

Let's move this earlier (before calling IntPort()).

For instance:

if (!gurl.has_port())
  return true;

[Paritosh Kumar, 2015/04/14 14:50:35]

Acknowledged.

+    if (gurl.SchemeIs("ftp")) {
+      return net::IsPortAllowedByFtp(port)
+             || net::IsPortAllowedByOverride(port);

[tyoshino (SeeGerritForStatus), 2015/04/13 14:28:16]

|| and && are placed at the end of the previous line in majority of this file.
Let's do that here too.

But rather I suggest we move this to between L513 and L514.

if (net::IsPortAllowedByOverride(port))
  return true;
if (gurl...

[Paritosh Kumar, 2015/04/14 14:50:35]

Acknowledged.

+    }
+    return net::IsPortAllowedByDefault(port)
+           || net::IsPortAllowedByOverride(port);
+  }
+  return true;
+}
+
 blink::WebThread* BlinkPlatformImpl::createThread(const char* name) {
   WebThreadImpl* thread = new WebThreadImpl(name);
   thread->TaskRunner()->PostTask(
       FROM_HERE, base::Bind(&BlinkPlatformImpl::UpdateWebThreadTLS,
                             base::Unretained(this), thread));
   return thread;
 }
 
 blink::WebThread* BlinkPlatformImpl::currentThread() {
   return static_cast<blink::WebThread*>(current_thread_slot_.Get());
@@ skipping 803 matching lines @@
   return WebString::fromUTF8(ui::KeycodeConverter::DomCodeToCodeString(
       static_cast<ui::DomCode>(dom_code)));
 }
 
 int BlinkPlatformImpl::domEnumFromCodeString(const WebString& code) {
   return static_cast<int>(ui::KeycodeConverter::CodeStringToDomCode(
       code.utf8().data()));
 }
 
 }  // namespace content